Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hydra: unset SSL_CERT_FILE #338536

Merged
merged 1 commit into from
Sep 9, 2024
Merged

nixos/hydra: unset SSL_CERT_FILE #338536

merged 1 commit into from
Sep 9, 2024

Conversation

tomodachi94
Copy link
Member

Description of changes

An ancient comment says to unset this variable after 16.03. Considering we've just gotten past 24.05, I think it's safe to remove this finally.

Tests still pass after this change.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94
nixos/hydra: unset SSL_CERT_FILE
2d8f095 
An ancient comment says to unset this variable after 16.03. Considering
we've just gotten past 24.05, I think it's safe to remove this finally.

Tests still pass after this change.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 31, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 31, 2024
@tomodachi94
Copy link
Member Author

@ofborg build nixosTests.hydra

@NickCao NickCao requested a review from Mindavi August 31, 2024 13:54
Mindavi
Mindavi approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream: NixOS/hydra@e5c757e

@Mindavi Mindavi merged commit f6b2548 into NixOS:master Sep 9, 2024
29 checks passed
@tomodachi94 tomodachi94 deleted the fix/nixos/hydra/remove-hardcoded-ssl-certs branch September 9, 2024 19:29
@tomodachi94
Copy link
Member Author

And the associated PR: NixOS/hydra#781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mindavi Mindavi Mindavi approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomodachi94 @Mindavi