Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bunbun: 1.3.0 -> 1.4.0 #336472

Merged
merged 1 commit into from
Aug 22, 2024
Merged

bunbun: 1.3.0 -> 1.4.0 #336472

merged 1 commit into from
Aug 22, 2024
+30 −17

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Aug 22, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/devraza/bunbun/releases/tag/v1.4.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage mentioned this pull request Aug 22, 2024
Closed
@GaetanLepage
Copy link
Contributor Author

@devraza it seems like you have not properly bumped the version in the Cargo.toml: https://git.devraza.giize.com/devraza/bunbun/src/tag/v1.4.0/Cargo.toml#L5

@GaetanLepage GaetanLepage marked this pull request as draft August 22, 2024 12:08
@devraza
Copy link

devraza commented Aug 22, 2024

Looks like you're right, I've forgotten to do that. Will do.

@devraza
Copy link

devraza commented Aug 22, 2024

@GaetanLepage I've updated the Cargo.toml with a new tag, v1.4.0-bump. 👍🏼

@GaetanLepage GaetanLepage marked this pull request as ready for review August 22, 2024 16:57
@GaetanLepage GaetanLepage requested a review from drupol August 22, 2024 16:57
@GaetanLepage
Copy link
Contributor Author

@GaetanLepage I've updated the Cargo.toml with a new tag, v1.4.0-bump. 👍🏼

Thanks !

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336472 run on x86_64-linux 1

1 package built:
  • bunbun

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336472 run on aarch64-darwin 1

1 package built:
  • bunbun

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336472 run on x86_64-darwin 1

1 package built:
  • bunbun

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336472 run on aarch64-linux 1

1 package built:
  • bunbun

@drupol drupol merged commit 8fe18a3 into NixOS:master Aug 22, 2024
42 of 44 checks passed
@GaetanLepage GaetanLepage deleted the bunbun branch August 22, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaetanLepage @devraza @drupol