Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pydy: drop nose dependency #336241

Merged
merged 1 commit into from
Sep 22, 2024
Merged

python312Packages.pydy: drop nose dependency #336241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions pkgs/development/python-modules/pydy/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,47 +6,53 @@
scipy,
sympy,
setuptools,
nose,
pytestCheckHook,
cython,
fetchpatch2,
}:

buildPythonPackage rec {
pname = "pydy";
version = "0.7.1";

pyproject = true;
build-system = [ setuptools ];

src = fetchPypi {
inherit pname version;
hash = "sha256-aaRinJMGR8v/OVkeSp1hA4+QLOrmDWq50wvA6b/suvk=";
};

build-system = [ setuptools ];

patches = [
# Migrate tests to pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove it at the next bump ? Maybe it would be nice to mention it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drupol, do you mind if I undraft this and merge? I don’t think we need to block on this as the patch will visibly fail on the next version bump, and it’s one of the few remaining uses of nose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine!

(fetchpatch2 {
Sigmanificient marked this conversation as resolved.
Show resolved Hide resolved
url = "https://github.com/pydy/pydy/commit/e679638fecf80def25f5ed20f01c49c5d931e4d8.patch?full_index=1";
hash = "sha256-wJmYkyc5Yh0152OyNL5ZbZJxmpX7C65Hqrms4gm3zt0=";
excludes = [
".github/workflows/oldest.yml"
".github/workflows/tests.yml"
"bin/test"
];
})
];

Sigmanificient marked this conversation as resolved.
Show resolved Hide resolved
dependencies = [
numpy
scipy
sympy
];

nativeCheckInputs = [
nose
pytestCheckHook
cython
];

checkPhase = ''
runHook preCheck

nosetests pydy

runHook postCheck
'';

pythonImportsCheck = [ "pydy" ];

meta = with lib; {
meta = {
description = "Python tool kit for multi-body dynamics";
homepage = "http://pydy.org";
license = licenses.bsd3;
maintainers = [ ];
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [ sigmanificient ];
};
}