Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun: 1.1.20 -> 1.1.24 #334890

Merged
merged 1 commit into from
Aug 21, 2024
Merged

bun: 1.1.20 -> 1.1.24 #334890

merged 1 commit into from
Aug 21, 2024

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Aug 15, 2024

Description of changes

Upgrade Bun to 1.1.24.

Note that it is still segfaulting in aarch64-linux. Investigating why.

(lldb) run
Process 77994 launched: '/Users/pan93412/Developer/oss/nixpkgs/result/bin/bun' (aarch64)
Process 77994 stopped
* thread #1, name = 'bun', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x5878946c)
    frame #0: 0x0000fffff7fd0428 ld-linux-aarch64.so.1`_dl_check_map_versions + 1208
ld-linux-aarch64.so.1`_dl_check_map_versions:
->  0xfffff7fd0428 <+1208>: ldrh   w0, [x1, #0x4]
    0xfffff7fd042c <+1212>: ldr    w2, [x1, #0x10]
    0xfffff7fd0430 <+1216>: and    w0, w0, #0x7fff
    0xfffff7fd0434 <+1220>: cmp    w25, w0

Things done

  • Built on platform(s)
    • x86_64-linux Broken
    • aarch64-linux Broken
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@smancill smancill merged commit 5bb9880 into NixOS:master Aug 21, 2024
35 of 36 checks passed
@donovanglover
Copy link
Member

Don't think this should've been merged since it fails to build on linux

@smancill
Copy link
Contributor

Oh, my bad, I checked ofborg and I didn't notice that Linux x86_64 was also broken.

@smancill
Copy link
Contributor

Reverted.

@dayblox
Copy link

dayblox commented Aug 21, 2024

Should we re-open it? Or even to 1.1.25

@smancill
Copy link
Contributor

I messed up by merging, so the best solution is a new PR.

@donovanglover
Copy link
Member

The update bot will automatically update if it builds with x86_64-linux. Right now it's failing though, so someone will need to figure out how to fix it.

@pan93412 pan93412 deleted the bun-1-1-24 branch August 22, 2024 03:02
@pan93412
Copy link
Contributor Author

pan93412 commented Aug 22, 2024

Should we re-open it? Or even to 1.1.25

shrinking RPATHs of ELF executables and libraries in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
shrinking /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
checking for references to /build/ in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25...
patching script interpreter paths in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
stripping (with command strip and flags -S -p) in  /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin
automatically fixing dependencies for ELF files
{'append_rpaths': [],
 'extra_args': [],
 'ignore_missing': [],
 'libs': [PosixPath('/nix/store/q94i3svccgqabp0c8izrn9kwxyfcn7gk-openssl-3.0.14-dev/lib'),
          PosixPath('/nix/store/zx8h9rnqvvwl36xv3pvvy91fxnsnahl7-openssl-3.0.14-bin/lib'),
          PosixPath('/nix/store/sgcjvcgs6rj7cqp2y136ibzs4056jzkj-openssl-3.0.14/lib')],
 'paths': [PosixPath('/nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25')],
 'recursive': True,
 'runtime_dependencies': []}
setting interpreter of /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
searching for dependencies of /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
    libc.so.6 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libpthread.so.0 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libdl.so.2 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libm.so.6 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
setting RPATH to: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
auto-patchelf: 0 dependencies could not be satisfied
rewriting symlink /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bunx to be relative to /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
Running phase: postPatchelf
@nix {"action":"setPhase","phase":"postPatchelf"}
/nix/store/mi0fh6mm5n693pz4c5p5p63jjs4w11mi-stdenv-linux/setup: line 1705:    82 Segmentation fault      SHELL="bash" $out/bin/bun completions $completions_dir

Bun 1.1.25 have not fix their segfault issue yet :(

@pan93412
Copy link
Contributor Author

pan93412 commented Aug 22, 2024

(gdb) run
Starting program: /nix/store/jd64j41kciymj76fic7xrfiswkjjb3bg-bun-1.1.25/bin/bun

Program received signal SIGSEGV, Segmentation fault.
_dl_check_map_versions (map=map@entry=0xfffff7fff350, verbose=verbose@entry=1, trace_mode=trace_mode@entry=0) at dl-version.c:263
warning: 263	dl-version.c: No such file or directory

https://github.com/bminor/glibc/blob/ef321e23c20eebc6d6fb4044425c00e6df27b05f/elf/dl-version.c#L263

Seems like there would be something wrong in the patched ELF…

@pan93412
Copy link
Contributor Author

Seems like it might be related to NixOS/patchelf#544 and NixOS/patchelf#244. Not sure if this is fixable. Matrix discussion.

Cc @donovanglover if we should raise it as an issue.

@Eveeifyeve
Copy link
Contributor

Eveeifyeve commented Aug 31, 2024

Should we re-open it? Or even to 1.1.25

shrinking RPATHs of ELF executables and libraries in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
shrinking /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
checking for references to /build/ in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25...
patching script interpreter paths in /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
stripping (with command strip and flags -S -p) in  /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin
automatically fixing dependencies for ELF files
{'append_rpaths': [],
 'extra_args': [],
 'ignore_missing': [],
 'libs': [PosixPath('/nix/store/q94i3svccgqabp0c8izrn9kwxyfcn7gk-openssl-3.0.14-dev/lib'),
          PosixPath('/nix/store/zx8h9rnqvvwl36xv3pvvy91fxnsnahl7-openssl-3.0.14-bin/lib'),
          PosixPath('/nix/store/sgcjvcgs6rj7cqp2y136ibzs4056jzkj-openssl-3.0.14/lib')],
 'paths': [PosixPath('/nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25')],
 'recursive': True,
 'runtime_dependencies': []}
setting interpreter of /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
searching for dependencies of /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bun
    libc.so.6 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libpthread.so.0 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libdl.so.2 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
    libm.so.6 -> found: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
setting RPATH to: /nix/store/kz7xglxzhad64v667wwpn8vrxhjwcbna-glibc-2.39-52/lib
auto-patchelf: 0 dependencies could not be satisfied
rewriting symlink /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25/bin/bunx to be relative to /nix/store/zfmdy0j1q714hb2xgqdgpcw7zwm65jjc-bun-1.1.25
Running phase: postPatchelf
@nix {"action":"setPhase","phase":"postPatchelf"}
/nix/store/mi0fh6mm5n693pz4c5p5p63jjs4w11mi-stdenv-linux/setup: line 1705:    82 Segmentation fault      SHELL="bash" $out/bin/bun completions $completions_dir

Bun 1.1.25 have not fix their segfault issue yet :(

What about 1.1.26?

Works on Darwin systems that is a check.
Looking to test specifically on nixos aarch64-linux using a raspberry pi, wherever my sd card is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants