-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bun: 1.1.20 -> 1.1.24 #334890
bun: 1.1.20 -> 1.1.24 #334890
Conversation
Don't think this should've been merged since it fails to build on linux |
Oh, my bad, I checked ofborg and I didn't notice that Linux x86_64 was also broken. |
Reverted. |
Should we re-open it? Or even to 1.1.25 |
I messed up by merging, so the best solution is a new PR. |
The update bot will automatically update if it builds with x86_64-linux. Right now it's failing though, so someone will need to figure out how to fix it. |
Bun 1.1.25 have not fix their segfault issue yet :( |
https://github.com/bminor/glibc/blob/ef321e23c20eebc6d6fb4044425c00e6df27b05f/elf/dl-version.c#L263 Seems like there would be something wrong in the patched ELF… |
Seems like it might be related to NixOS/patchelf#544 and NixOS/patchelf#244. Not sure if this is fixable. Matrix discussion. Cc @donovanglover if we should raise it as an issue. |
What about 1.1.26? Works on Darwin systems that is a check. |
Description of changes
Upgrade Bun to 1.1.24.
Note that it is still segfaulting in aarch64-linux. Investigating why.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.