python312Packages.webassets: drop nose dependency #334483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webassets: use patch
Sigmanificient
force-pushed
the
webassets
branch
from
2d46848 to
f70e539
Compare
| ''; | ||
|
|
||
| disabledTestPaths = [ | ||
| "tests/test_filters.py" # no module "distutils" |
There was a problem hiding this comment.
Did you try adding setuptools?
There was a problem hiding this comment.
in nativeCheckInputs?
There was a problem hiding this comment.
Still the same outcome:
____________________ ERROR collecting tests/test_filters.py ____________________
ImportError while importing test module '/build/webassets-2.0/tests/test_filters.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/l014xp1qxdl6gim3zc0jv3mpxhbp346s-python3-3.12.4/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/test_filters.py:15: in <module>
from distutils.spawn import find_executable
E ModuleNotFoundError: No module named 'distutils'
There was a problem hiding this comment.
Try adding distutils to dependencies or nativeCheckInputs as appropriate.
Sigmanificient
force-pushed
the
webassets
branch
from
f70e539 to
9a21413
Compare
SuperSandro2000
approved these changes
Aug 23, 2024
wegank
added
the
12.approvals: 1
emilazy
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 334483 run on aarch64-linux 1
12 packages failed to build:
- octoprint
- octoprint.dist
- pyload-ng
- pyload-ng.dist
- python311Packages.dukpy
- python311Packages.dukpy.dist
- python311Packages.flask-assets
- python311Packages.flask-assets.dist
- python312Packages.dukpy
- python312Packages.dukpy.dist
- python312Packages.flask-assets
- python312Packages.flask-assets.dist
4 packages built:
- python311Packages.webassets
- python311Packages.webassets.dist
- python312Packages.webassets
- python312Packages.webassets.dist
substituteStream() in derivation python3.12-flask-assets-2.1.0: ERROR: pattern static_path= doesn't match anything in file 'tests/test_integration.py'
|
@pyrox0 Did you want to handle this one too? Looks like the existing substitutions need updating or dropping. |
13 tasks
|
Submitted #348621, which builds on top of this PR and solves outstanding review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.