polkadot: fix compilation with rust 1.80 #334414
Merged
+36
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's targeting master but I tested this on staging-next to build with rust 1.80. |
ofborg
bot
added
11.by: package-maintainer
Pandapip1
reviewed
Aug 13, 2024
| # NOTE: bump `time` dependency to be able to build with rust 1.80 | ||
| # should be removed on the next release | ||
| (fetchpatch { | ||
| url = "https://github.com/paritytech/polkadot-sdk/pull/5149.patch"; |
There was a problem hiding this comment.
This should link to the commit's patch, since this PR is merged.
Suggested change
| url = "https://github.com/paritytech/polkadot-sdk/pull/5149.patch"; | |
| url = "https://github.com/paritytech/polkadot-sdk/commit/326342fe63297668d74fc69095090e53d43a2b0a.patch"; |
There was a problem hiding this comment.
If the PR is merged, this makes no difference. We only must fetch a commit if the PR is not merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Needed to build with Rust 1.80 (#332957).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.