-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canaille: init at 0.0.56, add module #333225
Conversation
20626cd
to
d304ad4
Compare
@dotlambda Do you think you can have a look at this? |
Thanks for the review. I'll squash later to keep the commit messages for now. |
@ofborg build canaille canaille.passthru.tests |
I just rebased and squashed. Weirdly I couldn't reproduce the build failure and also in the current version it builds on my machine. |
FYI Canaille 0.0.56 has been released.
|
Co-Authored-By: Auguste Baum <auguste.apple@gmail.com>
Co-Authored-By: Sofi <sofi+git@mailbox.org>
Co-Authored-By: Sofi <sofi+git@mailbox.org> Co-Authored-By: Janik <80165193+Janik-Haag@users.noreply.github.com>
Co-Authored-By: Janik <80165193+Janik-Haag@users.noreply.github.com>
Updated to 0.0.56, should be ready for review again! |
Successfully created backport PR for |
Thank you all for your hard work! |
Well thanks for your feedback on it :) |
Hi Kerstin @erictapen ! Have a nice day ! |
@funelie thanks, this is taken care of, we organise this through Summer of Nix. |
Hi there. Just as a curiosity to @funelie, how does these sponsorships get awarded? This PR's nix package is primarily based on my work in another repository https://github.com/soupglasses/phenix/blob/main/nixos/packages/servers/canaille/default.nix While the NixOS test and NixOS module are new, and its great to get canaille upstream, it feels a bit disappointing that someone gets the NLNet money for a package I created based on copyright infringement (MIT requires the copyright notice to be included in substantial copies of the code). This can also be further seen in the way dependencies are fetched, to the code being character by character the same. |
Hi @soupglasses, Indeed, they are the ones who define and manage this funding. In addition, it seems that this functionality has already given rise to a payment. Since redistribution is no longer relevant, our role ends here. I sincerely hope that you will receive a satisfactory response from NLnet. Kind regards. |
Description of changes
The module is already usable and can be deployed as can be seen here: https://canaille.erictapen.name
Most of the options are missing currently, and it would be nice to have a working deployment check in the NixOS test.Addresses:
I'll plan to get this into reviewable shape beginning next week.✔️Pinging people involved so far: @azmeuk @Janik-Haag @fricklerhandwerk (@soupglasses because I used parts of your package definition and you seem to be involved)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.