Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.rauth: drop #330417

Merged
merged 1 commit into from
Jul 28, 2024
Merged

python312Packages.rauth: drop #330417

merged 1 commit into from
Jul 28, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

I’m inclined to drop this; no in‐tree users, and “OAuth library that hasn’t been updated in a decade” is a very scary sequence of words. OAuth is security-critical and tricky, and there have certainly been OAuth best practices established in the past decade since this was touched at all. I suspect the only reason there isn’t an obvious knownVulnerabilities we can slap on this is because, with only 29 reverse dependencies on PyPI, it’s not widely used enough to have gotten attention from security researchers.

@Sigmanificient Sigmanificient force-pushed the rauth branch 2 times, most recently from cef182f to 1504d69 Compare July 27, 2024 14:03
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 27, 2024

"OAuth library that hasn’t been updated in a decade"

...yeah that is indeed quite scary 😅

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

LGTM. Please update the commit and PR titles.

@Sigmanificient Sigmanificient changed the title python312Packages.rauth: drop nose dependency python312Packages.rauth: drop Jul 27, 2024
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 27, 2024
@emilazy emilazy merged commit bd54356 into NixOS:master Jul 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants