Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.cgroup-utils: remove nose dependency and modernize #330287

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 26, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 27, 2024
@ofborg ofborg bot requested a review from layus July 27, 2024 00:31
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 27, 2024
@pyrox0 pyrox0 force-pushed the denose/cgroup-utils branch from 26cf942 to cef8efb Compare July 27, 2024 02:28
@pyrox0 pyrox0 force-pushed the denose/cgroup-utils branch from cef8efb to 62e632d Compare July 27, 2024 02:29
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330287 run on x86_64-linux 1

4 packages built:
  • python311Packages.cgroup-utils
  • python311Packages.cgroup-utils.dist
  • python312Packages.cgroup-utils
  • python312Packages.cgroup-utils.dist

@emilazy emilazy merged commit 283331a into NixOS:master Jul 27, 2024
8 of 9 checks passed
@pyrox0 pyrox0 deleted the denose/cgroup-utils branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants