python312Packages.citeproc-py: Remove nose dependency and re-enable tests #330237
Conversation
There was a problem hiding this comment.
Looks like this project might actually be becoming active again. They’ve moved to pynose upstream, but just as a test runner, so using pytestCheckHook should be fine.
There have been a bunch of fix commits since the last release, so maybe we should pin an unstable version until they figure out doing releases again.
| pythonImportsCheck = [ "citeproc" ]; | ||
|
|
||
| meta = with lib; { | ||
| meta = { | ||
| homepage = "https://github.com/brechtm/citeproc-py"; |
There was a problem hiding this comment.
This has moved to https://github.com/citeproc-py/citeproc-py.
|
(Sorry about all the nitpicking! I really appreciate everyone taking the initiative to deal with this massive list of packages; I just want to make sure we do what we can to get packages in a good state or else get rid of unnecessary burdens in the process.) |
|
No worries! I appreciate the nitpicks, they help improve future packages I submit and/or update! |
pyrox0
force-pushed
the
denose/citeproc-py
branch
from
8cc35a6 to
371dc89
Compare
pyrox0
force-pushed
the
denose/citeproc-py
branch
from
371dc89 to
fdc84b4
Compare
There was a problem hiding this comment.
Result of nixpkgs-review pr 330237 run on x86_64-darwin 1
8 packages built:
- python311Packages.citeproc-py
- python311Packages.citeproc-py.dist
- python311Packages.duecredit
- python311Packages.duecredit.dist
- python312Packages.citeproc-py
- python312Packages.citeproc-py.dist
- python312Packages.duecredit
- python312Packages.duecredit.dist
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.