nixos/radicle: fix node.listenAddress to support both IPv4 and IPv6 #330021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ju1m
force-pushed
the
radicle-fix-node-listenAddress
branch
from
262a0f5 to
d8401bc
Compare
martinetd
approved these changes
Jul 25, 2024
dpc
approved these changes
Jul 25, 2024
ofborg
bot
added
10.rebuild-darwin: 0
Aleksanaa
reviewed
Jul 26, 2024
| @@ -137,7 +137,7 @@ in | |||
| node = { | |||
| listenAddress = mkOption { | |||
| type = types.str; | |||
| default = "0.0.0.0"; | |||
| default = "[::]"; | |||
There was a problem hiding this comment.
New knowledge: This will also monitor IPv4 at the same time nodejs/node#9390
Aleksanaa
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
nix -L build -f . nixosTests.radiclewas failing lately becauseseed'sradicle-node.servicewas not listening on the IPv6 address tried byalice. It was working before,so presumably a previous version ofPreviously IPv6 was not enabled inradicle-nodewas makingalicealso try the IPv4, IOW this may also be a regression inradicle-node.nixosTests, #319308 recently changed that.Thanks to @martinetd for helping me to track down that one.
Things done
radicle-nodelisten on[::]instead of0.0.0.0.settingsfollowing up on nixos/radicle: init services #314440 (comment)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.