Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.telfhash: drop nose dependency #330005

Merged
merged 2 commits into from
Jul 27, 2024
Merged

python312Packages.telfhash: drop nose dependency #330005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea3b134
python312Packages.telfhash: drop nose dependency
Sigmanificient Jul 25, 2024
3fafc1a
python312Packages.telfhash: migrate to pyproject
Sigmanificient Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions pkgs/development/python-modules/telfhash/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
packaging,
pyelftools,
tlsh,
nose,
setuptools,
}:
buildPythonPackage rec {
pname = "telfhash";
version = "0.9.8";
format = "setuptools";
pyproject = true;

src = fetchFromGitHub {
owner = "trendmicro";
Expand All @@ -23,22 +23,21 @@ buildPythonPackage rec {
# The tlsh library's name is just "tlsh"
postPatch = ''
substituteInPlace requirements.txt \
--replace "python-tlsh" "tlsh" \
--replace "py-tlsh" "tlsh"
--replace-fail "python-tlsh" "tlsh" \
--replace-fail "py-tlsh" "tlsh" \
--replace-fail "nose>=1.3.7" ""
Comment on lines +26 to +28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: you can use pythonRemoveDeps here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t know about that, thank you! Sorry for not catching this. At least it was already present before in this case.

'';

propagatedBuildInputs = [
build-system = [ setuptools ];

dependencies = [
capstone
pyelftools
tlsh
packaging
];

nativeCheckInputs = [ nose ];

checkPhase = ''
nosetests
'';
doCheck = false; # no tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see there really is just no tests in the codebase, and @natsukium prefers that this is explicitely set

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright; very strange.


pythonImportsCheck = [ "telfhash" ];

Expand Down