vcpkg: fix binaries not being able to find libstdc++ #329033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guekka
reviewed
Jul 22, 2024
gracicot
suggested changes
Jul 23, 2024
gracicot
approved these changes
Jul 23, 2024
gracicot
suggested changes
Jul 24, 2024
There was a problem hiding this comment.
I don't have a strong opinion about that, but I would prefer if we stay explicit about which triplet we patch, and list them one by one. What do you think @h7x4 ?
Since there's a lot of triplets, lets keep the find command for matching all linux triplets automatically.
Before this change, if you tried to run a binary that was installed by vcpkg, then you would get this error: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory This change prevents that error from happening. Fixes NixOS#317553.
h7x4
approved these changes
Jul 26, 2024
13 tasks
|
Cool stuff, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
At the moment, if you try to run a binary that was installed by vcpkg, then you will get this error:
This PR prevents that error from happening.
Fixes #317553.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.