-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.torch: test torch.compile #328661
python312Packages.torch: test torch.compile #328661
Conversation
…accommodate different python versions
…ult python package sets
btw torch.compile works for cpu, but not for gpu rn |
You mean master or the triton PR? |
master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched from writers.writePython3Bin
to a simple runCommand
because it was easier to override python3Packages
this way. Either way I'll keep editing this thing
Possibly broke eval failure as:
|
Proposed the trivial change as #329511 |
Description of changes
Adds tests (including GPU/runtime checks) to document the premises for #328247
Status:
.#python311Packages.torch.tests.compileCpu
.#python312Packages.torch.tests.compileCpu
("Dynamo is not supported on Python 3.12+").#python3Packages.torch.tests.tester-compileCuda.gpuCheck
("Dynamo is not supported on Python 3.12+").#python311Packages.torch.tests.tester-compileCuda.gpuCheck
("ImportError: cannot import name 'get_cuda_version_key' from 'triton.common.backend'"); this functionality was working at the time of merging python3Packages.openai-triton: fix triton.common.build #325843Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.