Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.beaker: replace nose tests with pytest #327530

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

lavafroth
Copy link
Contributor

Description of changes

Addresses #326513.
Dependency nose was replaces by pytest in version 1.12.0 (2022-12-07).

  • Moved test exclusions from checkPhase to pytestFlagsArray.
  • pyproject = true PEP 517 migration

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Comment on lines 60 to +64
# Disable external tests because they need to connect to a live database.
# Also disable a test in test_cache.py called "test_upgrade" because
# it currently fails on darwin.
# Please see issue https://github.com/bbangert/beaker/issues/166
checkPhase = ''
nosetests \
-e ".*test_ext_.*" \
-e "test_upgrade" \
${lib.optionalString (!stdenv.isLinux) ''-e "test_cookie_expires_different_locale"''} \
-vv tests
'';
pytestFlagsArray = [
"--ignore=tests/test_memcached.py"
"--ignore-glob='tests/test_managers/test_ext_*'"
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use disabledTests here? Maybe not, because of the glob?

@lavafroth
Copy link
Contributor Author

lavafroth commented Jul 16, 2024 via email

@emilazy emilazy merged commit bad8a70 into NixOS:master Jul 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants