[WIP] clightning: fixes the compilation for the new future cln #312458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/fix-cln
branch
from
7620cdd to
b5fda33
Compare
Setting FUZZING... 0 Setting RUST... 0 Setting PYTHON... python3 @nix { "action": "setPhase", "phase": "buildPhase" } Running phase: buildPhase build flags: -j16 SHELL=/nix/store/087167dfxal194pm54cmcbbxsfy3cjgn-bash-5.2p26/bin/bash VERSION=v24.02 CC: gcc -DCLN_NEXT_VERSION="v24.05" -DBINTOPKGLIBEXECDIR="../libexec/c-lightning" -DCCAN_TAL_NEVER_RETURN_NULL=1 -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -Werror -Wno-maybe-uninitialized -Wshadow=local -std=gnu11 -g -fstack-protector-strong -Og -I ccan -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbacktrace/ -I external/gheap/ -I external/build-x86_64-unknown-linux-gnu/libbacktrace-build -I external/libsodium/src/libsodium/include -I external/libsodium/src/libsodium/include/sodium -I external/build-x86_64-unknown-linux-gnu/libsodium-build/src/libsodium/include -I . -I/usr/local/include -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS -DCOMPAT_V052=1 -DCOMPAT_V060=1 -DCOMPAT_V061=1 -DCOMPAT_V062=1 -DCOMPAT_V070=1 -DCOMPAT_V072=1 -DCOMPAT_V073=1 -DCOMPAT_V080=1 -DCOMPAT_V081=1 -DCOMPAT_V082=1 -DCOMPAT_V090=1 -DCOMPAT_V0100=1 -DCOMPAT_V0121=1 -c -o LD: gcc -Og config.vars -Lexternal/build-x86_64-unknown-linux-gnu -lwallycore -lsecp256k1 -ljsmn -lbacktrace -lsodium -L/usr/local/include -lm -lsqlite3 -lz -o /nix/store/087167dfxal194pm54cmcbbxsfy3cjgn-bash-5.2p26/bin/bash: line 1: tools/fromschema.py: cannot execute: required file not found /nix/store/087167dfxal194pm54cmcbbxsfy3cjgn-bash-5.2p26/bin/bash: line 1: tools/fromschema.py: cannot execute: required file not found make: *** [doc/Makefile:175: doc/lightning-addgossip.7.md] Error 127 make: *** Waiting for unfinished jobs.... make: *** [doc/Makefile:175: doc/lightning-addpsbtoutput.7.md] Error 127 /nix/store/087167dfxal194pm54cmcbbxsfy3cjgn-bash-5.2p26/bin/bash: line 1: tools/fromschema.py: cannot execute: required file not found make: *** [doc/Makefile:175: doc/lightning-autoclean-once.7.md] Error 127 /nix/store/087167dfxal194pm54cmcbbxsfy3cjgn-bash-5.2p26/bin/bash: line 1: tools/fromschema.py: cannot execute: required file not found make: *** [doc/Makefile:175: doc/lightning-autoclean-status.7.md] Error 127 Version updated Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/fix-cln
branch
from
b5fda33 to
77df48e
Compare
NixOSInfra
added
the
12. first-time contribution
|
Why is this a draft? The new clightning has just been released. |
Because cln is related one day ago and this PR was of 3 weeks ago before the first rc release, as mention in my PR description |
|
Let's close this in favor of a PR which updates the package. @vincenzopalazzo will you prepare it please? |
|
@prusnak Done! |
Link? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The future core lightning version that will be released this month will introduce a breaking change to our package by this PR ElementsProject/lightning#6995
The full issue is reported here ElementsProject/lightning#7315 and below is reported the failure during the compilation
P.S: this required that cln release the first rc release before merging (because need a version bumping)
Things done
Adding a new python file as input inside the
patchShebangsand add a build dependence that isjq.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.