-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbsd: init at 7.5 #311836
openbsd: init at 7.5 #311836
Conversation
03fdb46
to
7a7a107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no showstoppers, just some questions and advice from the freebsd mines
|
||
make -C $BSDSRCDIR/lib/libutil $makeFlags | ||
make -C $BSDSRCDIR/lib/libutil $makeFlags install | ||
symlink_so util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What packages have you tried compiling with this libc? I found that there were actually a bunch more libraries on freebsd which were required pretty much constantly, once you got into more interesting applications, like rust packages and stuff built with meson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the basics, we will also need to add more stuff
9315838
to
eda41d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you so much for splitting this into small, easily reviewable commits.
How come we're using NetBSD make and working around its differences instead of just building OpenBSD make?
pkgs/os-specific/bsd/openbsd/pkgs/libc/libpthread-no-werror.patch
Outdated
Show resolved
Hide resolved
OpenBSD doesn't have any I am still chuckling about this :) |
774a4b3
to
8fce018
Compare
Co-authored-by: Rahul Butani <rrbutani@users.noreply.github.com>
See: https://github.com/NixOS/nixpkgs/pull/246577/files#r1600650238 This code was breaking some thing for me, and I believe it was a mistake. I hink we *do* wanna link libc, since libc++ depends on it, but *don't* want to link an already-existing C++ standard library implementation. `-nostdlib++` without `-nostdlib` therefore seems correct to me. Without this change, we do indeed fail to link OpenBSD.
See the code comments for details Also replace a bad hard-coded `freebsd` with a flexible `*` wildcard in the `doFakeLibgcc` implementation.
Successfully created backport PR for |
Glad to see this PR has been merged, thank you for your work, @ali-abrar, can't wait to try it out! 💯 |
Sorry but this seems to break
|
Ah I wonder if that's because we updated LLVM and now the patch is already there and doesn't need backporting any more. |
patches reverted in: #315790 |
Sorry about that! Though it is nice LLVM 18 is already upgraded :) |
Description of changes
Add OpenBSD support similar to FreeBSD/NetBSD. We use some NetBSD tools to help bootstrap. Currently these are known o build:
Actually running these OpenBSD executables on OpenBSD will take more work, but @Ericson2314 thinks that is fine for now, because it is easier to fix that after there is a building foundation.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.