goose: update test skip list with newer tests #304240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes NixOS#302629 After updating from `3.15.0 -> 3.19.2` build for `goose` was failing. This was due to the tests failing esp on integration tests which required the docker darmon to be running. Tests with similar nature were already skipped, but on the upgraded version newer integration tests were added. This change adds these changes to the test skip list aswell. Skip following tests which require a docker daemon to be running - TestLockModeAdvisorySession - TestDialectStore - TestGoMigrationStats - TestPostgresSessionLocker Links: - Commit adding the new integration tests: pressly/goose@b2c483a
NixOSInfra
added
the
12. first-time contribution
RaghavSood
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
fixes #302629
After updating from
3.15.0 -> 3.19.2build forgoosewas failing.This was due to the tests failing esp on integration tests which
required the docker darmon to be running.
Tests with similar nature were already skipped, but on the upgraded
version newer integration tests were added.
Links:
Things done
This change adds these
changes to the test skip list aswell.
Skip following tests which require a docker daemon to be running
TestLockModeAdvisorySession
TestDialectStore
TestGoMigrationStats
TestPostgresSessionLocker
Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)sandbox = relaxedsandbox = trueTested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/)24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.