Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotosocial: skip more flakey tests #296069

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

blakesmith
Copy link
Contributor

golang 1.21.8 introduced some minor test suite breakages in gotosocial. Skip these tests for now. See: superseriousbusiness/gotosocial#2760

Will manually backport to #295584 to unblock 0.14.2 being updated in NixOS 23.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

golang 1.21.8 introduced some minor test suite breakages in gotosocial. Skip
these tests for now. See: superseriousbusiness/gotosocial#2760
@ofborg ofborg bot requested a review from misuzu March 15, 2024 19:39
@yayayayaka
Copy link
Member

Result of nixpkgs-review pr 296069 run on x86_64-linux 1

1 package built:
  • gotosocial

@yayayayaka yayayayaka merged commit e5b3215 into NixOS:master Mar 18, 2024
24 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants