llvmPackages_17.clangUseLLVM: apply omitted #220520 #295358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 12, 2024
| @@ -215,6 +215,7 @@ in let | |||
| (!stdenv.targetPlatform.isWasm && stdenv.targetPlatform.useLLVM or false) | |||
| "-lunwind" | |||
| ++ lib.optional stdenv.targetPlatform.isWasm "-fno-exceptions"; | |||
| nixSupport.cc-ldflags = lib.optionals (!stdenv.targetPlatform.isWasm) [ "-L${targetLlvmLibraries.libunwind}/lib" ]; | |||
There was a problem hiding this comment.
shouldn't this be:
(!stdenv.targetPlatform.isWasm && stdenv.targetPlatform.useLLVM or false)?
There was a problem hiding this comment.
unneeded as clangUseLLVM is only used when stdenv.targetPlatform.useLLVM is true.
ghost
approved these changes
Mar 27, 2024
ghost
merged commit 
rrbutani
added
the
6.topic: llvm/clang
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It seems that LLVM 17 is mistakenly omitted when rebasing #220520 on a up-to-date nixpkgs. Let’s fix it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.