cudaPackages.nsight_systems: fix crash #291471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
| in | ||
| { | ||
| # An ad hoc replacement for | ||
| # https://github.com/ConnorBaker/cuda-redist-find-features/issues/11 | ||
| env.rmPatterns = toString [ | ||
| "nsight-systems/*/*/libQt*" | ||
| "nsight-systems/*/*/libQt6*" |
There was a problem hiding this comment.
Are there any other matches to libQt* than libQt6*? If any, why would we not remove them?
There was a problem hiding this comment.
Note that the expression needs to be valid for other releases of cudaPackages too (cudaPackages_11_Y)
There was a problem hiding this comment.
@SomeoneSerge this removed libQtPropertyBrowser.so, which I couldn't find anywhere in Nixpkgs. As far as I could tell is not a Qt6 library and I suspect might be an internal library to nsight-systems, hence I changed the wildcard to not remove it. I could be wrong though.
| "nsight-systems/*/*/libstdc*" | ||
| "nsight-systems/*/*/libboost*" | ||
| "nsight-systems/*/*/lib{ssl,ssh,crypto}*" | ||
| "nsight-systems/*/*/lib{arrow,jpeg}*" | ||
| "nsight-systems/*/*/Mesa" | ||
| "nsight-systems/*/*/python/bin/python" | ||
| "nsight-systems/*/*/libexec" | ||
| "nsight-systems/*/*/Plugins" |
There was a problem hiding this comment.
Same question. These are prebuilt binaries which means they are presumed broken, so we do want to replace them with the respective ones from Nixpkgs.
There was a problem hiding this comment.
Agreed, but the additional code I added overwrites the Qt ones with links. These are the ones which remain:
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/CorePlugin/libCorePlugin.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/QuadDPlugin/libQuadDPlugin.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-decoration-client/libbradient.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-graphics-integration-client/libshm-emulation-server.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-graphics-integration-client/libvulkan-server.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-shell-integration/libwl-shell-plugin.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-shell-integration/libxdg-shell.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-shell-integration/libivi-shell.so
/nix/store/k3vnvanjxvfr0jvkf0y6ijjka7nk2km3-nsight_systems-2023.2.3.1004-bin/nsight-systems/2023.2.3/host-linux-x64/Plugins/wayland-shell-integration/libfullscreen-shell-v1.so
wegank
added
the
2.status: merge conflict
15 tasks
ConnorBaker
pushed a commit
to ConnorBaker/nixpkgs
that referenced
this pull request
Jun 14, 2024
ConnorBaker
pushed a commit
to ConnorBaker/nixpkgs
that referenced
this pull request
Sep 13, 2024
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #232458
Fixes several issues causing breakage of
nsysandnsys-uibinaries:Error: Nsight Systems #VERSION_RSPLIT# hasn't been installed with CUDA Toolkit #CUDA_MAJOR#.#CUDA_MINOR#host-linux-x64,target-linux-x64tobinoutputCould not find Qt platform plugin). Cherry-picked graham33@1ed0f5c.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.