sway: 1.8.1 -> 1.9.0

[raboof]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[oxalica]

🎉 It's released now. https://github.com/swaywm/sway/releases/tag/1.9

[norpol]

Thanks for bumping, just built it and verified with this that I'm running the new release

swaymsg -t get_version
sway version 1.9

for my configuration everything appears to be working as expected, screen lock works, xdg-desktop-portal-wlr/screen sharing works as well.

[trofi]

Result of nixpkgs-review pr 287805 run on x86_64-linux 1

2 packages failed to build:

• swayfx
• swayfx-unwrapped

8 packages built:

• nwg-panel
• nwg-panel.dist
• sway
• sway-contrib.grimshot
• sway-contrib.grimshot.man
• sway-unwrapped
• waybar
• wlprop

[eclairevoyant]

The change looks mostly good, but I believe we should also accordingly update the module to use wmenu instead of dmenu

@trofi regarding the build failure, it's because swayfx is a fork based off the older sway, and hence only support wlr 0.16.x. Swayfx upstream needs to bump.

[wineee]

Result of nixpkgs-review pr 287805 run on x86_64-linux 1

2 packages failed to build:

• swayfx
• swayfx-unwrapped

8 packages built:

swayfx still need wlroots_0_16, it shouldn't inherit sway's buildInput if it cannot be guaranteed to be released synchronously with sway

nixpkgs/pkgs/by-name/sw/swayfx-unwrapped/package.nix

Line 14 in cff84a2

(sway-unwrapped.override {

[eclairevoyant]

Created raboof#2 to address the swayfx issues

[thiagokokada]

Any concerns about merging this PR and fixing swayfx in a subsequent PR?

[oxalica]

I'm running with sway on this PR for some days and it works fine. The only concern to me is that we are accepting parameter wlroots_0_17, which causes downstream overriding to be confusingly .override { wlroots_0_17 = pkgs.wl_roots_0_16; /* or whatever */ }. But I don't think it's fixable for by-name packages currently. Merging as-is is fine to me.

[fpletz]

I agree with the point raboof#2 that swayfx should be decoupled from sway eventually. Ff that PR is merged into this PR's branch, I'd say we can merge this for now and deal with swayfx later.

[raboof]

But I don't think it's fixable for by-name packages currently.

I think I found a way - applied - if that seems to work let's merge like that, unless maintainers @primeos or @Synthetica9 have any input

[clushie]

[...] the module to use wmenu instead of dmenu

The file nixos/modules/programs/wayland/sway.nix:

nixpkgs/nixos/modules/programs/wayland/sway.nix

Line 122 in ebe6e80

swaylock swayidle foot dmenu

needs to be changed to wmenu otherwise this PR will break the default configuration. See the diff:

diff /nix/store/v1dwgcx2mp0phzh1inymxgapizbi7psc-sway-1.9/etc/sway/config /nix/store/jik0q6a6v7q5l6k04r6f0h7zjig5a7vf-sway-1.8.1/etc/sway/config
21c21
< set $menu dmenu_path | wmenu | xargs swaymsg exec --
---
> set $menu dmenu_path | dmenu | xargs swaymsg exec --
208c208
<     status_command while date +'%Y-%m-%d %X'; do sleep 1; done
---
>     status_command while date +'%Y-%m-%d %I:%M:%S %p'; do sleep 1; done

On that front please also merge #284343 which was released shortly before sway 1.9

[raboof]

needs to be changed to wmenu

updated, thanks!

please also merge #284343

it looks like that was already merged last month? did you mean to refer to another PR?

[clushie]

@raboof Sorry I just double checked the commit and it should basically be wmenu and dmenu now 🙈, dmenu is still used to generate a list of executables in $PATH

readlink -f `which dmenu_path`
/nix/store/hb7qbfbfdz5xw12fd9b37vyhkrcl6yd0-dmenu-5.2/bin/dmenu_path

Ah omg didn't realize this had the merged icon sorry

[raboof]

Updated