Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docfd: add fzf support #287785

Merged
merged 2 commits into from
Feb 11, 2024
Merged

docfd: add fzf support #287785

merged 2 commits into from
Feb 11, 2024

Conversation

chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Feb 10, 2024

Description of changes

  • Added fzf support to fix below issue.
  • Updated long description to match upstream.

Closes #287781

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@chewblacka chewblacka marked this pull request as ready for review February 10, 2024 14:24
@chewblacka chewblacka force-pushed the fix-docfd branch 3 times, most recently from fcf5286 to cff13e2 Compare February 10, 2024 17:13
@chewblacka chewblacka requested a review from NickCao February 11, 2024 08:57
pkgs/by-name/do/docfd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/do/docfd/package.nix Show resolved Hide resolved
@NickCao
Copy link
Member

NickCao commented Feb 11, 2024

Result of nixpkgs-review pr 287785 run on x86_64-linux 1

1 package built:
  • docfd

@NickCao NickCao merged commit 4a97fef into NixOS:master Feb 11, 2024
21 of 23 checks passed
@chewblacka chewblacka deleted the fix-docfd branch March 10, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docfd: missing fzf integration
2 participants