Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j4-dmenu-desktop: 2.18 -> unstable-2023-09-12, clean up #281288

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jan 16, 2024

Description of changes

Closes #281272
Closes #280925

This PR fixes the build for the package build by building from the currently latest commit.
It also has some cleanup:

Changes:

  • use finalAttrs instead of rec
  • use hash instead of sha256
  • add meta.changelog
  • add meta.mainProgram
  • meta.description: "recognize" -> "recognizes"
  • meta.license: gpl3 -> gpl3Only (not sure if gpl3Plus is acceptable, so I went with gpl3Only)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@cole-h
Copy link
Member

cole-h commented Jan 19, 2024

It looks like this package hasn't had a release in over 3 years now -- would you mind updating it to the latest commit (and change its version to unstable-)? It appears the compilation issue has been fixed upstream, as mentioned in this comment on a similar PR (#280925 (comment)), so we shouldn't need to set CXXFLAGS anymore after that.

@TomaSajt TomaSajt changed the title j4-dmenu-desktop: fix build, clean up j4-dmenu-desktop: 2.18 -> unstable-2023-09-12, clean up Jan 19, 2024
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appears to be working fine for me.

@cole-h cole-h merged commit ac72b47 into NixOS:master Jan 20, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: j4-dmenu-desktop
2 participants