j4-dmenu-desktop: 2.18 -> unstable-2023-09-12, clean up #281288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #281272
Closes #280925
This PR fixes the build for the package build by building from the currently latest commit.
It also has some cleanup:
Changes:
finalAttrs
instead ofrec
hash
instead ofsha256
meta.changelog
meta.mainProgram
meta.description
: "recognize" -> "recognizes"meta.license
:gpl3
->gpl3Only
(not sure if gpl3Plus is acceptable, so I went with gpl3Only)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.