Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-watcher: 0.23.1 -> 0.24.0 #279898

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Jan 9, 2024

Description of changes

Changelog: https://github.com/bazelbuild/bazel-watcher/releases

Closes #253706.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kolloch
Copy link
Contributor

kolloch commented Jan 12, 2024

Fixes #253706

@kolloch
Copy link
Contributor

kolloch commented Jan 16, 2024

What is needed to get this merged? I tested it on Linux x86.

@Strum355
Copy link
Contributor Author

What is needed to get this merged? I tested it on Linux x86.

I cant merge it myself, so we'd have to find someone who can. Maybe a ping in #253706?

@wegank wegank force-pushed the nsc/bazel-watcher branch from 9ce485b to f703e3f Compare January 23, 2024 00:58
@wegank wegank changed the title bazel-watcher 0.23.1 -> 0.24.0 bazel-watcher: 0.23.1 -> 0.24.0 Jan 23, 2024
@wegank
Copy link
Member

wegank commented Jan 23, 2024

@ofborg build bazel-watcher bazel-watcher.passthru.tests

@Strum355
Copy link
Contributor Author

@ofborg build bazel-watcher bazel-watcher.passthru.tests

Changing from sha256 to hash seems to be causing failures

@wegank wegank force-pushed the nsc/bazel-watcher branch from f703e3f to 8b2fa0f Compare January 23, 2024 22:21
@wegank
Copy link
Member

wegank commented Jan 23, 2024

Oh well, not all fetchers support hash...

@wegank
Copy link
Member

wegank commented Jan 24, 2024

Result of nixpkgs-review pr 279898 run on aarch64-darwin 1

1 package built:
  • bazel-watcher

@wegank wegank merged commit d4fce97 into NixOS:master Jan 24, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: bazel-watcher
3 participants