nvidia-x11.legacy_390: fix bug #277694
Merged
nvidia-x11.legacy_390: fix bug #277694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
kirillrdy
reviewed
Dec 30, 2023
TheBrainScrambler
force-pushed
the
nvidia-390-update
branch
from
9dc6a69 to
1d429fc
Compare
Kiskae
suggested changes
Jan 3, 2024
TheBrainScrambler
force-pushed
the
nvidia-390-update
branch
2 times, most recently
from
b2b87ee to
d0663e4
Compare
Kiskae
suggested changes
Jan 5, 2024
Said bug is described at https://bbs.archlinux.org/viewtopic.php?pid=2083439#p2083439
TheBrainScrambler
force-pushed
the
nvidia-390-update
branch
from
d0663e4 to
50bfc77
Compare
Kiskae
approved these changes
Jan 5, 2024
delroth
added
the
12.approvals: 1
|
Result of 10 packages marked as broken and skipped:
256 packages built:
|
kirillrdy
approved these changes
Jan 24, 2024
|
@TheBrainScrambler are you still interested in back-porting ? |
|
Sure ! I've never done a backporting before though, will be my first time |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-277694-to-release-23.11 origin/release-23.11
cd .worktree/backport-277694-to-release-23.11
git switch --create backport-277694-to-release-23.11
git cherry-pick -x 50bfc776d4e898528d46aa98ed29bb7e10fdc4bf |
|
@TheBrainScrambler automated way failed, you can follow instructions from github-actions bot there is also https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-backport-pull-requests feel free to ping me |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes the bug described at https://bbs.archlinux.org/viewtopic.php?pid=2083439#p2083439 for nvidia-x11.legacy_390. According to the thread, it might also fix the same bug for legacy_340 ?
Since this is a critical bug fix it might make sense to later backport it.
Also note that I've tested this on nixos-23.11, and not unstable
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.