Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbig2dec cross fix #275027

Merged
merged 1 commit into from
Dec 20, 2023
Merged

jbig2dec cross fix #275027

merged 1 commit into from
Dec 20, 2023

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Dec 17, 2023

Description of changes

Finalize fix cross-compilation from #266254
In #266254 we set configureScript variable, but then we need remove manual autogen.sh invocation as well

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@avnik avnik requested review from Mindavi and a user December 17, 2023 17:17
@avnik
Copy link
Contributor Author

avnik commented Dec 17, 2023

CC @Mindavi @amjoseph-nixpkgs

Consider backport of #266254 and this to staging-23.11 as well. (I have ongoing branch for it)

Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed to my aarch64 box; dependents like evince and gnome-frog are working fine

@Mindavi Mindavi merged commit 617e0a5 into NixOS:staging Dec 20, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants