Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iroh: 0.5.1 -> 0.11.0 #272988

Merged
merged 1 commit into from
Dec 13, 2023
Merged

iroh: 0.5.1 -> 0.11.0 #272988

merged 1 commit into from
Dec 13, 2023

Conversation

crimeminister
Copy link
Contributor

Description of changes

The successive changes included in the releases between v0.5.1 until v0.11.0 are described at a high level on the iroh releases page.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 272988 run on x86_64-linux 1

1 package built:
  • iroh

@crimeminister
Copy link
Contributor Author

@cameronfyfe I was thinking of trying my hand at a service module for running iroh as my next foray into NixOS. Are you the person that would review an attempt?

@cameronfyfe
Copy link
Contributor

@cameronfyfe I was thinking of trying my hand at a service module for running iroh as my next foray into NixOS. Are you the person that would review an attempt?

@crimeminister yes I can take a look and help test if you want to PR that, ultimately needs review by someone with commit rights though

@Janik-Haag
Copy link
Member

@ofborg build iroh

@Janik-Haag
Copy link
Member

@ofborg build iroh.passthru.tests

@Janik-Haag
Copy link
Member

Darwin was failing so let's try to rebuild it.
Will merge if it's fine afterwards.

@cameronfyfe I was thinking of trying my hand at a service module for running iroh as my next foray into NixOS. Are you the person that would review an attempt?

@crimeminister yes I can take a look and help test if you want to PR that, ultimately needs review by someone with commit rights though

Also feel free to ping for merge on that.

@Janik-Haag Janik-Haag merged commit ca63611 into NixOS:master Dec 13, 2023
34 of 36 checks passed
@crimeminister
Copy link
Contributor Author

Also feel free to ping for merge on that.

Thanks, will do!

@crimeminister crimeminister deleted the update-iroh branch December 13, 2023 22:29
@walkah walkah mentioned this pull request Dec 21, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants