Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo,rustc: 1.74.0 -> 1.74.1 #272969

Merged
merged 1 commit into from
Dec 16, 2023
Merged

cargo,rustc: 1.74.0 -> 1.74.1 #272969

merged 1 commit into from
Dec 16, 2023

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Dec 8, 2023

Description of changes

This PR can be safely retargeted to staging-next if we decide we want this in there.

Tested fd on aarch64-linux and firefox and thunderbird on x86_64-linux.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
Copy link
Member Author

@ofborg build fd

@anna328p
Copy link
Member

rust-lang/rust#117976

This update fixes a breaking bug in rustc that causes internal compiler errors on previously valid, stable code. I am currently unable to build some of my projects with 1.74.0.

@alyssais alyssais merged commit dbc3662 into NixOS:staging Dec 16, 2023
@alyssais alyssais deleted the rust-1.74.1 branch December 16, 2023 21:23
@alyssais alyssais mentioned this pull request Dec 20, 2023
13 tasks
@n3oney
Copy link
Contributor

n3oney commented Dec 20, 2023

rust-lang/rust#117976

This update fixes a breaking bug in rustc that causes internal compiler errors on previously valid, stable code. I am currently unable to build some of my projects with 1.74.0.

I've had the same experience - I couldn't compile the Asahi GPU drivers (in Rust)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants