Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocmPackages_5.llvm.base: override stdenv, set gccForLibs #272190

Closed
wants to merge 1 commit into from
Closed

rocmPackages_5.llvm.base: override stdenv, set gccForLibs #272190

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2023 •
edited by ghost
Loading

Description of changes

Needed in addition to:

@ghost ghost mentioned this pull request Dec 5, 2023
Merged
13 tasks
@ghost ghost requested a review from Madouura December 5, 2023 04:46
@ghost ghost changed the title rocmPackages_5.llvm.libc: override cmake and pkg-config rocmPackages_5.llvm.libc: override stdenv, cmake, pkg-config Dec 5, 2023
@ghost
Copy link
Author

ghost commented Dec 5, 2023

Wow I really wish AMD would not vendor their own copy of LLVM.

@ghost ghost changed the title rocmPackages_5.llvm.libc: override stdenv, cmake, pkg-config rocmPackages_5.llvm.libc: override stdenv, set gccForLibs Dec 5, 2023
@ghost
Copy link
Author

ghost commented Dec 5, 2023

This made it past hipblas so I think it's fixed; should know for sure in the next hour or so.

@ghost ghost changed the title rocmPackages_5.llvm.libc: override stdenv, set gccForLibs rocmPackages_5.llvm.base: override stdenv, set gccForLibs Dec 5, 2023
@Madouura
Copy link
Contributor

Can this be closed?

@ghost ghost closed this Jan 18, 2024
@ghost ghost deleted the pr/rocm/deconfusify branch January 18, 2024 08:55
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madouura Madouura Awaiting requested review from Madouura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Madouura