Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-23.05] forgejo: mark as insecure #271199

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

emilylange
Copy link
Member

Description of changes

Abort eval with the following error (exact formatting from my terminal):

Known issues:
 - Forgejo's API and web endpoints before version 1.20.5-1 are affected by multiple
critical security vulnerabilities.

Non-exhaustive list:
 - reveal comments from issues and pull-requests from private repositories
 - delete comments from issues and pull-requests
 - get private release attachments
 - delete releases and tags
 - get ssh deployment keys (public key)
 - get OAuth2 applications (except for the secret)
 - 2FA not being enforced for the container registry login (docker login)

There isn't a clear way how to backport and validate all those fixes to the now EOL
forgejo 1.19.x and we, the forgejo nixpkgs maintainers, decided against bumping the
release from 1.19.x to 1.20.x due to its breaking nature.
Given nixpkgs 23.11 has been released by now and nixpkgs 23.05 will reach EOL very
soon (2023-12-31), please update to nixpkgs 23.11 instead.

Upstream: https://forgejo.org/2023-11-release-v1-20-5-1/

https://forgejo.org/2023-11-release-v1-20-5-1/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@emilylange emilylange added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 30, 2023
@emilylange emilylange requested a review from mweinelt November 30, 2023 14:27
@NickCao NickCao changed the title forgejo: mark as insecure [release-23.05] forgejo: mark as insecure Nov 30, 2023
@mweinelt mweinelt requested review from LeSuisse and risicle November 30, 2023 14:52
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 30, 2023
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels reasonable to me, we do not have a lot of other choices anyway.

We probably should do the same for Gitea.

@LeSuisse LeSuisse merged commit b9fadb4 into NixOS:release-23.05 Dec 1, 2023
@emilylange emilylange deleted the release-23.05-forgejo branch December 1, 2023 20:39
@LeSuisse LeSuisse mentioned this pull request Dec 1, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants