Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-gcc-version: 12 -> 13 if !isDarwin && !isAarch64 #268097

Merged
65 commits merged into from Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
182357e
disable-warnings-if-gcc13: init
Dec 4, 2023
c3b574f
pycrypto: disable-warnings-if-gcc13
Dec 4, 2023
ad73ab2
efivar: disable-warnings-if-gcc13
Dec 4, 2023
ea98d01
btop: disable-warnings-if-gcc13
Dec 4, 2023
2f0321d
claws-mail: disable-warnings-if-gcc13
Dec 4, 2023
fc8b32d
tesseract: disable-warnings-if-gcc13
Dec 4, 2023
3eac13b
nixVersions: disable-warnings-if-gcc13
Dec 4, 2023
25bf55c
libgcc: pass --disable-plugins
Nov 18, 2023
ab32532
pybind: disable-warnings-if-gcc13
Dec 3, 2023
4509adf
gn: apply disable-warnings-if-gcc13
Dec 1, 2023
64873c3
blueprint: disable tests (time out)
Dec 3, 2023
09bad8e
curaengine: disable warnings if gcc13
Dec 3, 2023
eb1da85
kodi-inputstream-ffmpeg-direct: disable warnings if gcc13
Dec 3, 2023
95335aa
libe57format: disable warnings if gcc13
Dec 3, 2023
30e9253
python-qt: add disable-warnings-if-gcc13
Dec 3, 2023
d220d11
zeroc-ice: add disable-warnings-if-gcc13
Dec 3, 2023
6b8faec
google-cloud-cpp: add disable-warnings-if-gcc13
Dec 3, 2023
08e9f1f
curl-impersonate: pin-to-gcc12-if-gcc13
Dec 3, 2023
8268a1a
osrm-backend: disable-warnings-if-gcc13
Dec 3, 2023
5d5fd6f
proj: disable-warnings-if-gcc13
Dec 3, 2023
8ac1dd2
gmsh: disable-warnings-if-gcc13
Dec 3, 2023
89c108e
intel-media-sdk: disable-warnings-if-gcc13
Dec 3, 2023
83327f1
waylandpp: disable-warnings-if-gcc13
Dec 3, 2023
49e1736
gnuradio: disable-warnings-if-gcc13
Dec 3, 2023
33fc174
boringssl: disable-warnings-if-gcc13
Dec 3, 2023
c6968a2
rippled: disable-warnings-if-gcc13
Dec 3, 2023
f47afaf
litecoin: disable-warnings-if-gcc13
Dec 3, 2023
5975667
pcsx2: disable-warnings-if-gcc13
Dec 3, 2023
63ead95
python3Packages.ecos: disable-warnings-if-gcc13
Dec 3, 2023
5c037da
opencollada: disable-warnings-if-gcc13
Dec 3, 2023
0a4ea52
reproc: disable-warnings-if-gcc13
Dec 3, 2023
b40ab46
memorymapping: disable-warnings-if-gcc13
Dec 3, 2023
2ba85db
python3Packages.fasttext: disable-warnings-if-gcc13
Dec 3, 2023
e1445fd
gmsh: disable-warnings-if-gcc13
Dec 3, 2023
b1b000d
usbguard: disable-warnings-if-gcc13
Dec 3, 2023
34fb823
python3Packages.gmsh: typo fix
Dec 3, 2023
5390800
virtualbox: disable-warnings-if-gcc13
Dec 3, 2023
9a14750
openmw.tes3mp: disable-warnings-if-gcc13
Dec 4, 2023
259841c
python-qt: hit it in the head with a hammer
Dec 4, 2023
42b9b90
vertcoind: disable-warnings-if-gcc13
Dec 4, 2023
771db44
wownero: disable-warnings-if-gcc13
Dec 4, 2023
5911f28
litecoind: disable-warnings-if-gcc13
Dec 4, 2023
7cf63c9
pin-to-gcc12-if-gcc13: init
Dec 6, 2023
2abac5b
llvm: use gcc12Stdenv for llvmPackages<=14
Nov 24, 2023
bf33cd7
nix_2_3: pin-to-gcc12-if-gcc13
Dec 1, 2023
b9ccf1e
btor2tools: pin-to-gcc12-if-gcc13
Dec 1, 2023
c487794
bazel: pin-to-gcc12-if-gcc13
Dec 1, 2023
f36569e
binaryen: pin-to-gcc12-if-gcc13
Nov 27, 2023
aeaf50f
bobcat: pin-to-gcc12-if-gcc13
Nov 27, 2023
984a031
spike: pin-to-gcc12-if-gcc13
Nov 18, 2023
b9f3571
sdrpp: pin-to-gcc12-if-gcc13
Nov 18, 2023
d37357b
rocksdb: pin-to-gcc12-if-gcc13
Dec 4, 2023
d2495bd
crossguid: pin-to-gcc12-if-gcc13
Dec 3, 2023
f11d51f
libfilezilla: pin-to-gcc12-if-gcc13
Dec 4, 2023
678c9b2
bees: pin-to-gcc12-if-gcc13
Dec 3, 2023
df242a6
waylandpp: pin-to-gcc12-if-gcc13
Dec 3, 2023
06e3a69
envoy: pin-to-gcc12-if-gcc13
Dec 3, 2023
cc3057d
v8: pin-to-gcc12-if-gcc13
Dec 4, 2023
a0d48a4
openjfx: pin-to-gcc12-if-gcc13
Dec 4, 2023
e962c0b
qgrep: pin-to-gcc12-if-gcc13
Dec 4, 2023
2e952b5
texlive: pin-to-gcc12-if-gcc13
Dec 6, 2023
e46ecec
rocmPackages_5: pin stdenv to GCC 12
Madouura Dec 4, 2023
aa259f5
spirv-llvm-translator: disable-warnings-if-gcc13
Dec 4, 2023
d58aa2e
rocmPackages_5.llvm: use gcc12Stdenv if stdenv.cc.cc.isGNU>=13
Dec 5, 2023
195e990
default-gcc-version: 12 -> 13
Nov 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkgs/development/compilers/blueprint/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ stdenv.mkDerivation (finalAttrs: {
];

# requires xvfb-run
doCheck = !stdenv.isDarwin;
doCheck = !stdenv.isDarwin
&& false; # tests time out

checkPhase = ''
runHook preCheck
Expand Down
5 changes: 3 additions & 2 deletions pkgs/development/compilers/spirv-llvm-translator/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
, llvm
, spirv-headers
, spirv-tools
, disable-warnings-if-gcc13
}:

let
Expand Down Expand Up @@ -37,7 +38,7 @@ let
hash = "sha256-NoIoa20+2sH41rEnr8lsMhtfesrtdPINiXtUnxYVm8s=";
} else throw "Incompatible LLVM version.";
in
stdenv.mkDerivation {
disable-warnings-if-gcc13 (stdenv.mkDerivation {
pname = "SPIRV-LLVM-Translator";
inherit (branch) version;

Expand Down Expand Up @@ -91,4 +92,4 @@ stdenv.mkDerivation {
platforms = platforms.unix;
maintainers = with maintainers; [ gloaming ];
};
}
})
1 change: 1 addition & 0 deletions pkgs/development/libraries/gcc/libgcc/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ let
"--disable-intl"
"--enable-threads=posix"
"--with-glibc-version=${glibc.version}"
"--disable-plugin"

# these are required in order to prevent inhibit_libc=true,
# which will cripple libgcc's unwinder; see:
Expand Down
9 changes: 7 additions & 2 deletions pkgs/development/rocm-modules/5/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ callPackage
{ gcc12Stdenv # FIXME: Try removing this with a new ROCm release https://github.com/NixOS/nixpkgs/issues/271943
, callPackage
, recurseIntoAttrs
, symlinkJoin
, fetchFromGitHub
Expand Down Expand Up @@ -73,10 +74,11 @@ in rec {
# Broken, too many errors
rdc = callPackage ./rdc {
inherit rocmUpdateScript rocm-smi rocm-runtime;
stdenv = gcc12Stdenv;
# stdenv = llvm.rocmClangStdenv;
};

rocm-docs-core = python3Packages.callPackage ./rocm-docs-core { };
rocm-docs-core = python3Packages.callPackage ./rocm-docs-core { stdenv = gcc12Stdenv; };

## ROCm-Developer-Tools ##
hip-common = callPackage ./hip-common {
Expand Down Expand Up @@ -107,17 +109,20 @@ in rec {
rocprofiler = callPackage ./rocprofiler {
inherit rocmUpdateScript clr rocm-core rocm-thunk rocm-device-libs roctracer rocdbgapi rocm-smi hsa-amd-aqlprofile-bin;
inherit (llvm) clang;
stdenv = gcc12Stdenv;
};

# Needs GCC
roctracer = callPackage ./roctracer {
inherit rocmUpdateScript rocm-device-libs rocm-runtime clr;
stdenv = gcc12Stdenv;
};

# Needs GCC
rocgdb = callPackage ./rocgdb {
inherit rocmUpdateScript;
elfutils = elfutils.override { enableDebuginfod = true; };
stdenv = gcc12Stdenv;
};

rocdbgapi = callPackage ./rocdbgapi {
Expand Down
8 changes: 8 additions & 0 deletions pkgs/development/rocm-modules/5/llvm/base.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ lib
, stdenv
, gcc12Stdenv
, fetchFromGitHub
, rocmUpdateScript
, pkg-config
Expand Down Expand Up @@ -44,6 +45,13 @@
, isBroken ? false
}:

let stdenv' = stdenv; in
let stdenv =
if stdenv'.cc.cc.isGNU or false && lib.versionAtLeast stdenv'.cc.cc.version "13.0"
then gcc12Stdenv
else stdenv';
in

let
llvmNativeTarget =
if stdenv.isx86_64 then "X86"
Expand Down
17 changes: 9 additions & 8 deletions pkgs/development/rocm-modules/5/llvm/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ stdenv
{ # stdenv FIXME: Try changing back to this with a new ROCm release https://github.com/NixOS/nixpkgs/issues/271943
gcc12Stdenv
, callPackage
, rocmUpdateScript
, wrapBintoolsWith
Expand All @@ -12,18 +13,18 @@
let
## Stage 1 ##
# Projects
llvm = callPackage ./stage-1/llvm.nix { inherit rocmUpdateScript; };
clang-unwrapped = callPackage ./stage-1/clang-unwrapped.nix { inherit rocmUpdateScript llvm; };
lld = callPackage ./stage-1/lld.nix { inherit rocmUpdateScript llvm; };
llvm = callPackage ./stage-1/llvm.nix { inherit rocmUpdateScript; stdenv = gcc12Stdenv; };
clang-unwrapped = callPackage ./stage-1/clang-unwrapped.nix { inherit rocmUpdateScript llvm; stdenv = gcc12Stdenv; };
lld = callPackage ./stage-1/lld.nix { inherit rocmUpdateScript llvm; stdenv = gcc12Stdenv; };

# Runtimes
runtimes = callPackage ./stage-1/runtimes.nix { inherit rocmUpdateScript llvm; };
runtimes = callPackage ./stage-1/runtimes.nix { inherit rocmUpdateScript llvm; stdenv = gcc12Stdenv; };

## Stage 2 ##
# Helpers
bintools-unwrapped = callPackage ./stage-2/bintools-unwrapped.nix { inherit llvm lld; };
bintools = wrapBintoolsWith { bintools = bintools-unwrapped; };
rStdenv = callPackage ./stage-2/rstdenv.nix { inherit llvm clang-unwrapped lld runtimes bintools; };
rStdenv = callPackage ./stage-2/rstdenv.nix { inherit llvm clang-unwrapped lld runtimes bintools; stdenv = gcc12Stdenv; };
in rec {
inherit
llvm
Expand All @@ -40,8 +41,8 @@ in rec {

## Stage 3 ##
# Helpers
clang = callPackage ./stage-3/clang.nix { inherit llvm lld clang-unwrapped bintools libc libunwind libcxxabi libcxx compiler-rt; };
rocmClangStdenv = overrideCC stdenv clang;
clang = callPackage ./stage-3/clang.nix { inherit llvm lld clang-unwrapped bintools libc libunwind libcxxabi libcxx compiler-rt; stdenv = gcc12Stdenv; };
rocmClangStdenv = overrideCC gcc12Stdenv clang;

# Projects
clang-tools-extra = callPackage ./stage-3/clang-tools-extra.nix { inherit rocmUpdateScript llvm clang-unwrapped; stdenv = rocmClangStdenv; };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{ callPackage
{ stdenv
, callPackage
, rocmUpdateScript
, llvm
}:

callPackage ../base.nix rec {
inherit rocmUpdateScript;
inherit stdenv rocmUpdateScript;
targetName = "clang-unwrapped";
targetDir = "clang";
extraBuildInputs = [ llvm ];
Expand Down
5 changes: 3 additions & 2 deletions pkgs/development/rocm-modules/5/llvm/stage-1/lld.nix
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{ callPackage
{ stdenv
, callPackage
, rocmUpdateScript
, llvm
}:

callPackage ../base.nix rec {
inherit rocmUpdateScript;
inherit stdenv rocmUpdateScript;
buildMan = false; # No man pages to build
targetName = "lld";
targetDir = targetName;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/rocm-modules/5/llvm/stage-1/llvm.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
}:

callPackage ../base.nix {
inherit rocmUpdateScript;
inherit stdenv rocmUpdateScript;
requiredSystemFeatures = [ "big-parallel" ];
isBroken = stdenv.isAarch64; # https://github.com/RadeonOpenCompute/ROCm/issues/1831#issuecomment-1278205344
}
3 changes: 2 additions & 1 deletion pkgs/development/rocm-modules/5/llvm/stage-1/runtimes.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{ lib
, stdenv
, callPackage
, rocmUpdateScript
, llvm
}:

callPackage ../base.nix rec {
inherit rocmUpdateScript;
inherit stdenv rocmUpdateScript;
buildDocs = false;
buildMan = false;
buildTests = false;
Expand Down
1 change: 1 addition & 0 deletions pkgs/development/rocm-modules/5/llvm/stage-2/rstdenv.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ overrideCC stdenv (wrapCCWith rec {
inherit bintools;
libcxx = runtimes;
cc = clang-unwrapped;
gccForLibs = stdenv.cc.cc;

extraPackages = [
llvm
Expand Down
5 changes: 3 additions & 2 deletions pkgs/development/tools/build-managers/gn/generic.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ stdenv, lib, fetchgit, darwin, writeText
, ninja, python3
, disable-warnings-if-gcc13
, ...
}:

Expand All @@ -17,7 +18,7 @@ let
#endif // OUT_LAST_COMMIT_POSITION_H_
'';

in stdenv.mkDerivation {
in disable-warnings-if-gcc13 (stdenv.mkDerivation {
pname = "gn-unstable";
inherit version;

Expand Down Expand Up @@ -57,4 +58,4 @@ in stdenv.mkDerivation {
platforms = platforms.unix;
maintainers = with maintainers; [ stesie matthewbauer primeos ];
};
}
})
5 changes: 3 additions & 2 deletions pkgs/games/openmw/tes3mp.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@
, luajit
, makeWrapper
, symlinkJoin
, disable-warnings-if-gcc13
}:

# revisions are taken from https://github.com/GrimKriegor/TES3MP-deploy

let
# raknet could also be split into dev and lib outputs
raknet = stdenv.mkDerivation {
raknet = disable-warnings-if-gcc13 (stdenv.mkDerivation {
pname = "raknet";
version = "unstable-2020-01-19";

Expand All @@ -35,7 +36,7 @@ let
installPhase = ''
install -Dm555 lib/libRakNetLibStatic.a $out/lib/libRakNetLibStatic.a
'';
};
});

coreScripts = stdenv.mkDerivation {
pname = "corescripts";
Expand Down
7 changes: 5 additions & 2 deletions pkgs/tools/package-management/nix/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
, fetchpatch2
, runCommand
, Security
, pin-to-gcc12-if-gcc13

, storeDir ? "/nix/store"
, stateDir ? "/nix/var"
Expand Down Expand Up @@ -151,14 +152,16 @@ let
pkg;

in lib.makeExtensible (self: ({
nix_2_3 = (common {
nix_2_3 = pin-to-gcc12-if-gcc13 ((common {
version = "2.3.17";
hash = "sha256-EK0pgHDekJFqr0oMj+8ANIjq96WPjICe2s0m4xkUdH4=";
patches = [
patch-monitorfdhup
];
maintainers = with lib.maintainers; [ flokli raitobezarius ];
}).override { boehmgc = boehmgc-nix_2_3; };
}).override {
boehmgc = boehmgc-nix_2_3;
});

nix_2_10 = common {
version = "2.10.3";
Expand Down
6 changes: 5 additions & 1 deletion pkgs/tools/typesetting/tex/texlive/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
- source: ../../../../../doc/languages-frameworks/texlive.xml
- current html: https://nixos.org/nixpkgs/manual/#sec-language-texlive
*/
{ stdenv, lib, fetchurl, runCommand, writeShellScript, writeText, buildEnv
{ lib
#, stdenv
, gcc12Stdenv
, fetchurl, runCommand, writeShellScript, writeText, buildEnv
, callPackage, ghostscript_headless, harfbuzz
, makeWrapper, installShellFiles
, python3, ruby, perl, tk, jdk, bash, snobol4
Expand All @@ -11,6 +14,7 @@
, useFixedHashes ? true
, recurseIntoAttrs
}:
let stdenv = gcc12Stdenv; in
let
# various binaries (compiled)
bin = callPackage ./bin.nix {
Expand Down
Loading