cargo-raze: increase open file descriptors limits for tests on darwin #267265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://hydra.nixos.org/build/239024688/nixlog/2 https://hydra.nixos.org/build/239009073/nixlog/2 ``` thread '<unnamed>' panicked at 'Cannot build local tokio runtime: Os { code: 24, kind: Uncategorized, message: "Too many open files" }', /private/tmp/nix-build-cargo-raze-0.16.0.drv-0/cargo-raze-0.16.0-vendor.tar.gz/httpmock/src/lib.rs:1436:14 ``` Seems to be a typical darwin failure, some packages already bump file descriptors limit to 1024 (same as default in some Linux distros, default darwin value seems to be 256 these days) Also has a report upstream google/cargo-raze#544 ZHF: NixOS#265948
NixOSInfra
added
the
12. first-time contribution
boltzmannrain
added
the
0.kind: ZHF Fixes
|
👍 A build fix first pr, nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bump file descriptor limit for tests on Darwin
https://hydra.nixos.org/build/239024688/nixlog/2
https://hydra.nixos.org/build/239009073/nixlog/2
Seems to be a typical darwin failure, some packages already bump file descriptors limit to 1024 (same as default in some Linux distros, default darwin value seems to be 256 these days)
Also has a report upstream
google/cargo-raze#544
ZHF: #265948
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)