Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpExtensions.memprof: init at 3.0.2 #266086

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Nov 7, 2023

Description of changes

This PR adds memprof PHP extension: https://github.com/arnaud-lb/php-memory-profiler

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

This LGTM as usual ! Let's wait for the eval before merging.

@drupol
Copy link
Contributor

drupol commented Nov 8, 2023

@GrahamcOfBorg build phpExtensions.memprof

@drupol drupol merged commit 0499c5b into NixOS:master Nov 8, 2023
30 of 32 checks passed
@gaelreyrol gaelreyrol deleted the php-extension-memprof-init branch November 8, 2023 08:09
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
13 tasks
nyabinary pushed a commit to nyabinary/nixpkgs that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants