texlive.withPackages: respect .outputSpecified even for old style packages #265645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
First subtle sharp edge in the backward compatibility code: when detecting
.pkgs = [ ... ]
, we assume that the package is in the old format and convert it. However, if an output was specified, we lose that information.Since specifying an output only makes sense for new style packages, we can and must disable conversion in those cases.
Example:
should install the TeX files of LaTeXML in the environment, and nothing else. Right now LaTeXML gets re-converted to the new style (due to the still present
.pkgs
) and you get both binaries and TeX files.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)