Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive.withPackages: respect .outputSpecified even for old style packages #265645

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

xworld21
Copy link
Contributor

@xworld21 xworld21 commented Nov 5, 2023

Description of changes

First subtle sharp edge in the backward compatibility code: when detecting .pkgs = [ ... ], we assume that the package is in the old format and convert it. However, if an output was specified, we lose that information.

Since specifying an output only makes sense for new style packages, we can and must disable conversion in those cases.

Example:

texlive.withPackages (ps: [ perlPackages.LaTeXML.tex ])

should install the TeX files of LaTeXML in the environment, and nothing else. Right now LaTeXML gets re-converted to the new style (due to the still present .pkgs) and you get both binaries and TeX files.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Nov 5, 2023
@xworld21 xworld21 requested a review from veprbl November 8, 2023 20:27
@xworld21
Copy link
Contributor Author

xworld21 commented Nov 8, 2023

@veprbl I forgot to tag you here: this fixes a bug compared to the behaviour I claim in the new docs.

@veprbl veprbl merged commit 04277cd into NixOS:master Nov 8, 2023
19 checks passed
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
13 tasks
nyabinary pushed a commit to nyabinary/nixpkgs that referenced this pull request Nov 14, 2023
@xworld21 xworld21 deleted the texlive-respect-outputspecified branch March 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants