-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avidemux: fix missing libraries at startup #265545
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i fixed a similar issue #272491
what was happening is that cmake is installing the libs in
lib64
but the rpath points tolib
so fixup strips the rpath because it is invalid. if you add something like.just before
fixupPhase
inbuildCommand
then the binaries should end up with the proper rpaths making the LD_LIBRARY_PATH changes unnecessary.I validated this by just running
ldd result/bin/.*
before and after the change. after the libs are found, before they are not. seems like the binaries are double wrapped tho.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-n-n-a-l-e-e I'm not sure I understood what your suggestion tries to fix - I tested the package now and it builds and runs fine for me, also the Nix code is clean IMO. The only issue is that the binaries are wrapped twice, as mentioned in my other comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion removes having to add
(placeholder "out")/lib
to theLD_LIBRARY_PATH
as the RPATH will not get stripped by the fixupPhase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without my suggestion,
patchelf --print-rpath result-orig/bin/..*
shows:with my suggestion
patchelf --print-rpath result-mod/bin/..*
shows/nix/store/8wssaqcpr5gg4hcjns6mfgkwmgfa4fb6-avidemux-2.8.1/lib
is listed in the RPATHand if you run
ldd
ldd result-orig/bin/..*
ldd result-mod/bin/..*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your suggestion seems better to me ... since it sounds like you already have it implemented, do you want to open a PR for it and we can close this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, though, i've never run the program before -- i just recognized the issue.
#281173