Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-packages.nix: fix path to emulator-hook.sh #265134

Merged
merged 1 commit into from Nov 3, 2023
Merged

all-packages.nix: fix path to emulator-hook.sh #265134

merged 1 commit into from Nov 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2023 •
edited by ghost
Loading

Description of changes

Fixes rebase-race-condition in #264903

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Nov 3, 2023
Merged
13 tasks
@ghost ghost requested a review from Artturin November 3, 2023 03:00
@ghost ghost marked this pull request as ready for review November 3, 2023 03:00
@ghost ghost mentioned this pull request Nov 3, 2023
Merged
13 tasks
@ghost ghost marked this pull request as draft November 3, 2023 03:01
@ghost ghost changed the base branch from master to staging November 3, 2023 03:01
@ghost ghost marked this pull request as ready for review November 3, 2023 03:02
@Artturin Artturin merged commit 660a8f6 into NixOS:staging Nov 3, 2023
4 of 5 checks passed
@ghost ghost deleted the fix-path-to-emulator-hook branch November 3, 2023 03:17
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artturin