Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc: disable tests for pkgsStatic #265093

Merged
merged 1 commit into from
Nov 3, 2023
Merged

jemalloc: disable tests for pkgsStatic #265093

merged 1 commit into from
Nov 3, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Nov 2, 2023

Description of changes

fixes pkgsStatic.ruff as reported in #243324

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Nov 2, 2023

Ah right, for some reason I had LD_PRELOAD in my head and thought this wouldn't work anyway for static binaries, but that's not true.

@yu-re-ka yu-re-ka merged commit 38cc0ce into NixOS:master Nov 3, 2023
23 of 24 checks passed
@yu-re-ka yu-re-ka deleted the jemalloc-static branch November 3, 2023 00:49
@hmenke
Copy link
Member

hmenke commented Nov 3, 2023

Thank you both very much for fixing this so quickly!

@cafkafk cafkafk mentioned this pull request Nov 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants