Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: create dummy crtstuff on S390 as well #262885

Merged
1 commit merged into from Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkgs/development/compilers/gcc/common/libgcc-buildstuff.nix
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@ in
#
# No rule to make target '../../../gcc-xx.x.x/libgcc/config/loongarch/crti.S', needed by 'crti.o'. Stop.
#
# For LoongArch64, a hacky workaround is to simply touch them,
# For LoongArch64 and S390, a hacky workaround is to simply touch them,
# as the platform forces .init_array support.
#
# https://www.openwall.com/lists/musl/2022/11/09/3
#
+ lib.optionalString stdenv.targetPlatform.isLoongArch64 ''
touch libgcc/config/loongarch/crt{i,n}.S
# 'parsed.cpu.family' won't be correct for every platform.
This conversation was marked as resolved.
Show resolved Hide resolved
+ lib.optionalString (stdenv.targetPlatform.isLoongArch64 || stdenv.targetPlatform.isS390) ''
touch libgcc/config/${stdenv.targetPlatform.parsed.cpu.family}/crt{i,n}.S
This conversation was marked as resolved.
Show resolved Hide resolved
''
1 change: 1 addition & 0 deletions pkgs/test/cross/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ let
pkgs.pkgsCross.m68k.stdenv
pkgs.pkgsCross.aarch64-multiplatform.pkgsBuildTarget.gcc
pkgs.pkgsCross.powernv.pkgsBuildTarget.gcc
pkgs.pkgsCross.s390.stdenv
pkgs.pkgsCross.mips64el-linux-gnuabi64.stdenv
pkgs.pkgsCross.mips64el-linux-gnuabin32.stdenv
pkgs.pkgsCross.mingwW64.stdenv
Expand Down