Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sha256 with hash in documentation and all-packages.nix #254967

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Sep 13, 2023

Description of changes

  • Add a new sha256-to-SRI.py maintainer script, which is both useable as a library, or as an executable which attempts to replace sha256 attributes with hash ones.

  • Replace deprecated uses of sha256 with hash in the documentation: both nixpkgs', NixOS', and comments under lib/.

    Remaining occurences of sha256 under doc/ are in the context of functions which do not yet accept hash parameters:

    • BEAM, Dart, and Coq language frameworks;
    • Docker image builder.
  • Replace uses of sha256 with hash in all-packages.nix

Things done

  • Ran mypy on the new maintainer script
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 6.topic: rust 6.topic: policy discussion 6.topic: lib The Nixpkgs function library labels Sep 13, 2023
@nbraud nbraud force-pushed the sha256-to-hash/top-level branch 2 times, most recently from f2befca to 9de6ba7 Compare September 13, 2023 17:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 13, 2023
@mkg20001 mkg20001 merged commit 7b737ac into NixOS:master Sep 15, 2023
@nbraud nbraud deleted the sha256-to-hash/top-level branch September 15, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: rust 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants