tests.cc-wrapper: run on more compilers #253752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
16 tasks
Artturin
commented
Sep 7, 2023
There was a problem hiding this comment.
None of the jobs.tests are run here because of 36587a5
There's a useful snippet in the comments if we want to run these
tests = forAllSystems
(system:
let pkgs = pkgsFor system; in
pkgs.callPackages ../test {});
Artturin
force-pushed
the
testsccwrapper
branch
from
fc6d3c0
to
324f74f
Compare
Artturin
commented
Sep 7, 2023
There was a problem hiding this comment.
tests.cc-wrapper.gccMultiStdenv fails with
cc-wrapper-test-gcc> checking whether sanitizers are fully functional... ./sanitizers: error while loading shared libraries: libstdc++.so.6: wrong ELF class: ELFCLASS32
3c9dd2a
to
ae26b91
Compare
Artturin
commented
Sep 7, 2023
There was a problem hiding this comment.
tests.cc-wrapper.llvmPackages_15.libcxx fails with
cc-wrapper-test-clang-libcxx> checking whether compiler builds valid C++ binaries...
cc-wrapper-test-clang-libcxx> -/nix/store/8zxgqm6d879hskwh5g1l4crysl01kdv0-binutils-2.40/bin/ld: cannot find l: No such file or directory
$ diff pkgs/development/compilers/llvm/15/libcxx/default.nix pkgs/development/compilers/llvm/16/libcxx/default.nix
50,51d49
< ] ++ lib.optionals stdenv.hostPlatform.isMusl [
< ../../libcxx-0001-musl-hacks.patch
82,83d79
< # (Backport fix from 16, which has LIBCXX_ADDITIONAL_LIBRARIES, but 15
< # does not appear to)
86c82
< # -DLLVM_ENABLE_PROJECTS=libcxxabi;libunwind
---
> # -DLLVM_ENABLE_PROJECTS=libcxxabi;libunwinder
89,90c85
< # "-DLIBCXX_ADDITIONAL_LIBRARIES=unwind"
< "-DCMAKE_SHARED_LINKER_FLAGS=-lunwind"
---
> "-DLIBCXX_ADDITIONAL_LIBRARIES=unwind"the cause does not appear to be any of these diffs
Artturin
commented
Sep 7, 2023
There was a problem hiding this comment.
tests.cc-wrapper.gcc49Stdenv fails with
cc-wrapper-test-gcc> checking whether sanitizers are fully functional...
cc-wrapper-test-gcc> In file included from /nix/store/3c3vrabg4yy87y4qx8zsy5x2vdg132j5-sanitizers.c:1:0:
cc-wrapper-test-gcc> /nix/store/ix23ggz0k9vrhbl6ig7bwqcgf396rwmx-gcc-4.9.4/lib/gcc/x86_64-unknown-linux-gnu/4.9.4/include/sanitizer/asan_interface.h:53:3: error: unknown type name 'bool'
cc-wrapper-test-gcc> bool __asan_address_is_poisoned(void const volatile *addr);
cc-wrapper-test-gcc> ^
cc-wrapper-test-gcc> /nix/store/ix23ggz0k9vrhbl6ig7bwqcgf396rwmx-gcc-4.9.4/lib/gcc/x86_64-unknown-linux-gnu/4.9.4/include/sanitizer/asan_interface.h:66:40: error: unknown type name 'bool'
cc-wrapper-test-gcc> void *addr, bool is_write, size_t access_size);
cc-wrapper-test-gcc> ^
cc-wrapper-test-gcc> /nix/store/ix23ggz0k9vrhbl6ig7bwqcgf396rwmx-gcc-4.9.4/lib/gcc/x86_64-unknown-linux-gnu/4.9.4/include/sanitizer/asan_interface.h:88:3: error: unknown type name 'bool'
cc-wrapper-test-gcc> bool __asan_symbolize(const void *pc, char *out_buffer,
cc-wrapper-test-gcc> ^
cc-wrapper-test-gcc> /nix/store/ix23ggz0k9vrhbl6ig7bwqcgf396rwmx-gcc-4.9.4/lib/gcc/x86_64-unknown-linux-gnu/4.9.4/include/sanitizer/asan_interface.h:98:3: error: unknown type name 'bool'
cc-wrapper-test-gcc> bool __asan_get_ownership(const void *p);
cc-wrapper-test-gcc> ^
|
@ofborg build tests.cc-wrapper |
|
Will have to limit multilib gcc wrapper to x86_l64-inux only error: Multilib gcc-wrapper-12.3.0 not supported for ‘x86_64-darwin’ |
|
@ofborg build tests.cc-wrapper |
|
Eval fails seems to be because of this on the 3 other platfomrs the attr is there |
ignore `llvmPackages_latest`, it's an alias and it'll be a duplicate. ignore `llvmPackages_git`, it's not supposed to be used in nixpkgs and may be broken.
Show what libc is used, otherwise there's indication what libc is being used. Ex in gccMultiStdenv.
this is much easier to read.
…g for linux and x86_64 they're only supported on x86_64-linux
This reverts commit d33a309f2c9f85c28cb897e623503f210057a77a.
commit caused ofborg-eval to fail with
```
$ nix-build pkgs/top-level/release.nix -A tests.cc-wrapper.gcc10Stdenv.aarch64-darwin
error: evaluation aborted with the following error message: 'cannot find attribute `tests.cc-wrapper.gcc10Stdenv''
```
on the 3 other platfomrs the attr is there
Artturin
force-pushed
the
testsccwrapper
branch
from
7ece79e
to
2cd6014
Compare
|
@ofborg build tests.cc-wrapper |
|
@ofborg build tests.cc-wrapper.supported |
Artturin
force-pushed
the
testsccwrapper
branch
from
2cd6014
to
085abfc
Compare
|
@ofborg build tests.cc-wrapper.supported |
Artturin
force-pushed
the
testsccwrapper
branch
2 times, most recently
from
777848d
to
ca50953
Compare
|
@ofborg build tests.cc-wrapper.supported |
Artturin
force-pushed
the
testsccwrapper
branch
from
ca50953
to
3f8e333
Compare
|
@ofborg build tests.cc-wrapper.supported |
Artturin
force-pushed
the
testsccwrapper
branch
from
3f8e333
to
47eab8c
Compare
|
@ofborg build tests.cc-wrapper.supported |
|
aarch64-darwin fails with EDIT: workaround added |
filter out llvmPackages <=10 on aarch64-darwin, they're marked broken and availableOn doesn't filter broken packages
Artturin
force-pushed
the
testsccwrapper
branch
from
47eab8c
to
2d15039
Compare
|
@ofborg build tests.cc-wrapper.supported |
|
Good enough, will try removing the special cases later. |
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #216273
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)