Revert "qt5.qtbase: fix cross" #251681
Merged
Revert "qt5.qtbase: fix cross" #251681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: cross-compilation
ckiee
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Given the massive (10251) amount of rebuilds (ofborg-eval) in the original PR, it's important we revert it before the next hydra eval (~9h I think?) regardless of the PR's merits.
ofborg
bot
requested review from
qknight,
bkchr,
matthewbauer,
periklis,
OPNA2608 and
abbradar
|
I have cancel permissions if needed. Don't hesitate to ping me or the folks
in the Staging room or the NixOS org infrastructure room on Matrix.
Le dim. 27 août 2023 à 01:22, ckie ***@***.***> a écrit :
… ***@***.**** approved this pull request.
Given the massive (10251) amount of rebuilds (ofborg-eval
<https://gist.githubusercontent.com/GrahamcOfBorg/a1613fe75648d23f540c6759ef0a75fd/raw/570f3dd073bc228442aa97bb042beee74ac9605b/Changed%2520Paths>)
in the original PR, it's important we revert it before the next hydra eval
(~9h i think?)
—
Reply to this email directly, view it on GitHub
<#251681 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMZRGPVRWNCVW6MLNF5F3XXKAJTANCNFSM6AAAAAA374GCYM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I can cancel jobs, too, I believe, if it is needed... (Though I'm unsure, it may be limited to Mobile NixOS.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #227900
This change should have gone through
staging, as it is definitely a mass rebuild.cc @amjoseph-nixpkgs @vcunat @RaitoBezarius @dotlambda.
Feel free to re-open targeting the appropriate branch.