Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-comp: fix cross compilation #251555

Closed
wants to merge 8 commits into from
Closed

cosmic-comp: fix cross compilation #251555

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2023

Description of changes

This PR includes these two PRs, plus the changes from my review needed to make cosmic-* cross compile.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Aug 26, 2023
12 tasks
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 8.has: package (new) labels Aug 26, 2023
@ofborg ofborg bot requested a review from alyssais August 26, 2023 10:06
This is the change suggested here:

- #251365 (comment)
@ghost
Copy link
Author

ghost commented Aug 26, 2023

@ofborg build pkgsCross.aarch64-multiplatform.cosmic-comp

@ofborg build pkgsCross.aarch64-multiplatform.cosmic-panel

@ofborg build pkgsCross.aarch64-multiplatform.cosmic-applets

@alyssais
Copy link
Member

alyssais commented Oct 7, 2023

I think this can be closed? I got everything, right?

@nyabinary
Copy link
Contributor

I think I'm not sure though. cc @amjoseph-nixpkgs

@ghost
Copy link
Author

ghost commented Oct 22, 2023

I think this can be closed? I got everything, right?

If not I'll reopen it.

@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/cosmic-comp/cross branch January 23, 2024 06:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants