-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethrun: init at 0.1.0 #24819
ethrun: init at 0.1.0 #24819
Conversation
@dbrock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres, @jefdaj and @chris-martin to be potential reviewers. |
I got |
Looks like this wasn't deterministic after all. @mbrock has been working on trying to fix it but he seems to have run into some pretty deep hair-pulling problems relating to the Nix–Rust-industrial complex. |
It's pretty weird that there seem to be two different hashes. @bennofs and Travis both get the Beyond that problem is the problem that Rust packages with Cargo dependencies from GitHub don't work in the sandbox (I think). |
@mbrock They should work in the sandbox just fine. Nix does allow network access to derivations that specify the output hash beforehand (called fixed output derivations), which the fetch-deps derivation for rust packages does (this is why you get the "hash not deterministic" problem in the first case). Did you build this against the
|
@mbrock I think the isssue is this: nix-community/nix-index#2 (comment) |
Ok, that hash difference was fixed in bd78749. |
Ok, interesting! In my own investigations, I actually got this same error as on Hydra but only sometimes -- rerunning the exact same build ( I didn't investigate further because I'm quite ignorant of exactly how Cargo works, and this seemed very mysterious. |
@mbrock I think the current rust infrastructure is broken in various ways. I'll try to replace it with a better one. To be honest, I don't know how it even works correclty most of the time right now. Are you using sandboxed builds? |
Motivation for this change
The
ethrun
program is a dependency of some other Ethereum-related utilities. It is a relatively stable basic tool that changes infrequently.https://github.com/dapphub/ethrun
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)