Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fio: fix cross-compilation #245793

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fio: fix cross-compilation #245793

merged 1 commit into from
Jul 28, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 27, 2023 •
edited
Loading

Without the change pkgsCross.aarch64-multiplatform.fio fails build as:

$ nix build -f. pkgsCross.aarch64-multiplatform.fio
...
fio-aarch64-unknown-linux-gnu> Bad option --build=x86_64-unknown-linux-gnu
fio-aarch64-unknown-linux-gnu> Bad option --host=aarch64-unknown-linux-gnu

The fix uses CROSS_COMPILE= option instead.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jul 27, 2023
@trofi trofi mentioned this pull request Jul 27, 2023
Closed
@trofi
Copy link
Contributor Author

trofi commented Jul 27, 2023

Should fix #245617

@trofi
Copy link
Contributor Author

trofi commented Jul 27, 2023

Result of nixpkgs-review pr 245793 run on x86_64-linux 1

3 packages built:
  • fio
  • kdiskmark
  • xfstests

@trofi @NickCao
fio: fix cross-compilation
cf25fdf 
Without the change `pkgsCross.aarch64-multiplatform.fio` fails build as:

```
$ nix build -f. pkgsCross.aarch64-multiplatform.fio
...
fio-aarch64-unknown-linux-gnu> Bad option --build=x86_64-unknown-linux-gnu
fio-aarch64-unknown-linux-gnu> Bad option --host=aarch64-unknown-linux-gnu
```

Co-authored-by: Nick Cao <nickcao@nichi.co>
@trofi
Copy link
Contributor Author

trofi commented Jul 28, 2023

I just realized i typo'ed makeFlages as makeFLags (and it worked). I think it's enough to use $CC already set by stdenv.cc.

I left only configurePlatforms = [ ];, which is enough.

@NickCao
Copy link
Member

NickCao commented Jul 28, 2023

@ofborg build pkgsCross.aarch64-multiplatform.fio

@NickCao NickCao merged commit 8cacc05 into NixOS:master Jul 28, 2023
@trofi trofi deleted the fix-cross-fix branch July 28, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @NickCao