Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catppuccin-catwalk: init at 0.4.0 #245476

Merged
merged 1 commit into from
Jul 28, 2023
Merged

catppuccin-catwalk: init at 0.4.0 #245476

merged 1 commit into from
Jul 28, 2023

Conversation

ryanccn
Copy link
Member

@ryanccn ryanccn commented Jul 26, 2023 •
edited
Loading

Description of changes

https://github.com/catppuccin/toolbox

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 26, 2023
@getchoo
Copy link
Member

getchoo commented Jul 26, 2023

Result of nixpkgs-review pr 245476 run on x86_64-linux 1

4 packages built:
  • catppuccin-catwalk (python310Packages.catppuccin-catwalk)
  • catppuccin-catwalk.dist (python310Packages.catppuccin-catwalk.dist)
  • python311Packages.catppuccin-catwalk
  • python311Packages.catppuccin-catwalk.dist

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 26, 2023
natsukium
natsukium reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please reformat with nixpkgs-fmt?

pkgs/development/python-modules/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
@ryanccn ryanccn force-pushed the catppuccin-catwalk-init branch 2 times, most recently from d339978 to 23ee7c6 Compare July 26, 2023 07:31
@ryanccn ryanccn requested a review from natsukium July 26, 2023 07:32
@ryanccn ryanccn force-pushed the catppuccin-catwalk-init branch 2 times, most recently from 90bd2d0 to b7116ef Compare July 27, 2023 03:54
@ryanccn ryanccn requested a review from natsukium July 27, 2023 03:54
natsukium
natsukium reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits
besides these, LGTM.

pkgs/development/tools/misc/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/catppuccin-catwalk/default.nix Outdated Show resolved Hide resolved
@ryanccn ryanccn force-pushed the catppuccin-catwalk-init branch from b7116ef to 1a5e701 Compare July 27, 2023 05:54
@ryanccn ryanccn requested a review from natsukium July 27, 2023 05:54
@drupol drupol merged commit 3914805 into NixOS:master Jul 28, 2023
@ryanccn ryanccn deleted the catppuccin-catwalk-init branch July 28, 2023 10:00
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@drupol drupol drupol approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanccn @getchoo @drupol @natsukium @Janik-Haag