Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: move isMips64n32 from meta.broken to meta.badPlatforms #245300

Merged
merged 1 commit into from Sep 7, 2023
Merged

boost: move isMips64n32 from meta.broken to meta.badPlatforms #245300

merged 1 commit into from Sep 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2023

Description of changes

Presence in meta.badPlatforms can be tested with lib.meta.availableOn, but meta.broken cannot.

I use this to compile as much of my routers' userspace as possible for Mips64n32, and to automatically detect the few binaries (mostly those which use boost) cannot and build those for Mips64n64.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Presence in meta.badPlatforms can be tested with
lib.meta.availableOn, but meta.broken cannot.

I use this to compile as much of my routers' userspace as possible
for Mips64n32, and to automatically detect the few binaries (mostly
those which use boost) cannot and build those for Mips64n64.
@ghost ghost mentioned this pull request Jul 25, 2023
12 tasks
@Artturin Artturin merged commit d78d760 into NixOS:master Sep 7, 2023
9 of 10 checks passed
@ghost ghost deleted the pr/boost/move-mipsN32-to-badPlatforms branch January 23, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant