Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: add ajoseph for kernel/manual-config.nix #245137

Merged
merged 1 commit into from Jul 24, 2023
Merged

CODEOWNERS: add ajoseph for kernel/manual-config.nix #245137

merged 1 commit into from Jul 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2023

Description of changes

It is hard to get people to test changes to our kernel expression on anything other than x86_64 and aarch64 before merging changes.

Therefore, I would like to be notified of PRs opened agains this file, so that I can hopefully catch breakage before it is merged, rather than afterwards.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It is hard to get people to test changes to our kernel expression on
anything other than x86_64 and aarch64 before merging changes.

Therefore, I would like to be notified of PRs opened agains this
file, so that I can hopefully catch breakage before it is merged,
rather than afterwards.
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@Ma27 Ma27 merged commit 9da8193 into NixOS:master Jul 24, 2023
6 checks passed
@ghost ghost deleted the pr/amjoseph-codeowners-kernel branch July 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants