Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxManualConfig: restore functionality of isModular and buildDTBs #244447

Merged
1 commit merged into from Jul 20, 2023
Merged

linuxManualConfig: restore functionality of isModular and buildDTBs #244447

1 commit merged into from Jul 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2023

Description of changes

Since #221707 the isModular and buildDTBs parameters no longer function properly -- they now control only whether or not these elements are copied to the outpath; they are build unconditionally in any case.

This commit reverts the part of #221707 which caused this behavior change.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Since #221707 the `isModular`
and `buildDTBs` parameters no longer function properly -- they now
control only whether or not these elements are copied to the
outpath; they are build unconditionally in any case.

This commit reverts the part of #221707 which caused this behavior
change.
@ghost ghost mentioned this pull request Jul 20, 2023
12 tasks
@ghost ghost merged commit 42fcf08 into NixOS:master Jul 20, 2023
7 checks passed
@ghost ghost mentioned this pull request Jul 25, 2023
2 tasks
@ghost ghost deleted the pr/fix/restore-ability-to-build-kernel-without-modules branch January 23, 2024 06:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants