Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: ping @amjoseph-nixpkgs on certain trees #243391

Merged
1 commit merged into from Jul 14, 2023
Merged

CODEOWNERS: ping @amjoseph-nixpkgs on certain trees #243391

1 commit merged into from Jul 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2023

Description of changes

I don't claim ownership of anything, but I would like to be notified of PRs opened against the following paths where I've put a lot of work into cleanup and deduplication:

  • lib/systems
  • pkgs/stdenv
  • pkgs/build-support/cc-wrapper
  • pkgs/development/compilers/gcc
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Apparently CODEOWNERS is how you tell github you want to be notified
of such things.

I don't claim ownership of anything, but I would like to be notified
of PRs opened against the following paths where I've put a lot of
work into cleanup and deduplication:

  lib/systems
  pkgs/stdenv
  pkgs/build-support/cc-wrapper
  pkgs/development/compilers/gcc

Apparently CODEOWNERS is how you tell github you want to be notified
of such things.
@ghost ghost merged commit c656296 into NixOS:master Jul 14, 2023
@ghost ghost deleted the pr/codeowners branch July 14, 2023 06:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant